Repository navigation
feat(helm): support revision-aware topology spread constraints - #75
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
topologySpreadConstraintsin the Helm Deployment pod template with backward-compatible[]default.strategyoverride (defaulting to Kubernetes behavior), allowing a delete-first initial migration from required anti-affinity on a saturated cluster.matchLabelKeys: [pod-template-hash].Why
Required pod anti-affinity is enforced in both directions: old RobotLB pods can reject incoming pods regardless of their
pod-template-hash. Topology spread provides per-revision scheduling, so updated replicas can share nodes with the old revision. The first rollout still needs to account for old hard anti-affinity rules, hence the optional rollout strategy.Verification
helm-unittestcases, executed by the existinghelm-unittestCI job.Upgrade note
On a 3-node/3-replica cluster currently using required anti-affinity, remove
affinity.podAntiAffinity, settopologySpreadConstraintsas documented, and temporarily setstrategy.rollingUpdate.maxSurge: 0andmaxUnavailable: 1. Restore Kubernetes default strategy after all old pods have terminated.