Repository navigation
Say what the dead-code gates hold, not how they got there - #73
Merged
Merged
Conversation
AGENTS.md asks a comment to carry the constraint the next person has to respect, and specifically not the bug that prompted it. The CI step for the manifest check explained itself by describing a commit that had once slipped through. It now says why the step is here when verify runs the same check. The section also gave the full reason for the one exempt dependency, which knip.ts carries beside the entry. It names the exemption and points there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md asks a comment to carry the constraint the next person must respect, not the bug that prompted it. The CI step for the manifest check described a commit that skipped the hook. This PR says why the step belongs here when verify runs the same check.
No code changes here. Only comments and Markdown move, so behaviour is identical. AGENTS.md names the one exempt dependency and points at knip.ts, which carries the reason beside the entry.
pnpm verify.pnpm go:deadcodestill reports nothing.pnpm check:dead-codestill reports zero.