Repository navigation
feat: add page numbers to ksaa_finance_economics and apply the paper-dictionary review - #63
Merged
Merged
Conversation
…dictionary review Review of ksaa_finance_economics (Q141442356) against the printed dictionary: - set the page of 1872 terms - correct 40 terms to match the printed wording - remove 1 erroneous row, term 581413 (nbr_entries 1893 -> 1892) - keep as is the 20 terms for which the reviewer gave no page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ksaa_finance_economics(معجم المصطلحات المالية والاقتصادية, Q141442356) was imported from Siwar without page numbers. A reviewer checked its 1893 terms against the printed dictionary; this PR applies that review.pageset (range 7-477)nbr_entries: 1893 -> 1892.updated_atis set on every changed term and on the dictionary row.Removed row
581413
صندوق الاستثمار العقاريّ/Real estate investment trust (REIT), flaggedخطأ يلزم حذفهby the reviewer.Corrected terms
31 rows are flagged
معدل/معدلةby the reviewer:9 more were edited by the reviewer without a flag. They are applied as well, as in #51:
The new Arabic of 581458,
ضغوط خارجي, is probably a typo forضغوط خارجية. It is stored as written in the spreadsheet — worth a second look against the paper.Terms without a page
The reviewer gave no page and no comment for these 20 terms; they keep
page = NULL:580305 Interest Rates, 580402 Share Issuance with the Suspension of Primary Rights, 580425 Insolvency, 580543 Account Name, 580577 Economies of Scale, 580595 Fixed Liability, 580731 Affirmed, 580908 Ministry of Finance Circular, 581119 Governance, 581129 Service, 581131 Customer Service, 581176 Compliance Degree, 581226 Credit Watch, 581241 Account Number, 581242 Bidding Number, 581274 Oil Price, 581534 Board Member, 581589 Transit Process, 581865 Beneficiary Centricity, 581891 Prospective Beneficiary
Pages worth a second look
Five pages are far from those of their alphabetical neighbours, which may be a typo or a different headword in the printed edition. They are stored as given:
Checks
make regenerate_dumpsran in full:make validatepasses with an unchanged baseline, and the MariaDB FULLTEXT smoke test returns results.arabterm.db.gz, both SQL dumps and the Dictionaries table ofREADME.mdare regenerated from the samearabterm.db.