Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 11 remains BLOCKED: removing CPU entropy traversal cannot preserve the completed decode validation contract with the current Metal status checks. No production shortcut is enabled.
This diagnostic creates a valid restart JPEG and removes its first entropy interval while retaining marker structure. The existing packet builder rejects it with a typed Huffman error. A privately modified test packet modeling marker-only preparation is accepted by full-image GPU status checks while producing different pixels; a final-MCU ROI also succeeds because the malformed interval is unselected. Production continues to use the fully validated packet builder. This test is a blocker reproduction, not a claim that the optimization has been implemented.
Based directly on main; the rejected task 01 refill candidate is not selected. Validation on local Apple M4 Pro: the named test ran with J2K_REQUIRE_METAL_RUNTIME=1, one passed and none skipped; package formatting and diff checks passed. Clippy tests passed with the repository's existing non-production allocation-lint exceptions. Initial strict test Clippy exposed those allocation lints and a long test body; duplicate decode setup was consolidated and the final hardware test rerun successfully.
Performance: NOT MEASURED, because no production optimization was selected. Remaining requirements for any future shortcut include segment-local bounds, entropy and terminal validation, error parity, full-image and partial-route parity, shared-consumer/CUDA validation, and the exact-head manual GPU workflow before merge. No manual workflow was dispatched. CUDA remains deferred to the end as requested.