Fix subsampled decode panic with nonzero image origins - #117
Merged
Merged
Conversation
jcwal1516
changed the base branch from
perf/codec-batching-and-metal-kernels
to
main
September 27, 2026 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 166-byte input found by wsi-rs fuzzing panics in j2k-native 0.11.1 when a subsampled component has a nonzero image origin. The store path subtracts the full component origin from reduced-resolution coordinates. Index reconstructed coefficients relative to their own grid and intersect the copied region with that grid in floating-point and integer storage.
The retained reproducer checks full and cropped decoding at reductions 0, 1, and 2 against the full decoded pixels. It failed with subtraction overflow before the fix; all 25 component-plane tests now pass. Library Clippy and targeted test Clippy pass with the repository's existing test-only allocation lint policy.
Stacked on #116; required for the wsi-rs dependency upgrade.