Prepare WSI 0.7 reader and Metal release - #16
Merged
Merged
Conversation
jcwal1516
marked this pull request as ready for review
September 7, 2026 04:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares the pending reader and Metal changes for WSI 0.7. Region reads use bounded plans and batches, MIRAX and cache payloads use positional reads, and automatic acceleration calibrates bounded work. It fixes sparse Philips/generic TIFF transparency, oversized synthetic NDPI tile requests, and metadata parsing for supported retired progressive JPEG DICOM syntaxes.
Hamamatsu VMU now opens base/map NGR companions and optional JPEG macros. Native reads preserve RGB16 samples and use bounded positional reads across storage columns. The OpenSlide C shim converts RGB12 tiles before composition, supporting fractional lower-resolution reads and transparent edges. Tests use generated files based on OpenSlide's published NGR layout; real scanner-generated VMU compatibility remains unverified.
Public corpus coverage includes Trestle, Philips-4, generic TIFF, deidentified real SOF2/YBR_RCT/YBR_ICT frames with independent reference pixels, an independently encoded lossless OpenJPH fixture, and a complete source-independent SVCACHE fixture. Separate SlideIO 2.9.0 probes validate native ZVI channel pixels and selected VSI regions, but do not establish full pyramid/geometry parity.
Validation:
cargo xtask validatepassed: 1049 default, 1056 OpenSlide-feature, and 1103 Metal-feature tests, plus formatting, Clippy, release builds and docs.This remains a draft. The unfiltered corpus release gate still requires VMU, Olympus VSI and Zeiss ZVI manifest evidence. J2K dependency updates await J2K 0.11.1 publication. Full RC preflight, dependency/fuzz/performance/platform checks and publication remain outstanding; no release gate has been waived.