This repository was archived by the owner on Apr 25, 2026. It is now read-only.
[codex] Fix alive cats sort crash after quick refresh - #97
Merged
Merged
Conversation
Preserves table selection and scroll position during quick room refreshes by emitting layoutAboutToBeChanged + changePersistentIndexList + layoutChanged on the source model instead of a full reset. The proxy's dynamic sort/filter handles re-sorting automatically, so the explicit proxy invalidate and sortByColumn re-apply in _on_room_patch are no longer needed.
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CatTableModel.apply_room_patch()pathWhy
The remaining crash report pointed to sorting the
Alive Catstab right after the save updated. The quick-refresh path was mutating live cats and emitting a rawlayoutChanged, which left the sorted roster in a riskier state than a full model reset.Impact
This makes the post-update
Alive Catstable refresh more defensively, especially when the user clicks a sort header right after the game writes a new save.Root cause
Quick room refresh updated
cat.room/cat.statusunderneath an already sorted proxy/view pair and only emittedlayoutChanged. That was too weak for the sorted roster path; resetting the model is the safer way to force Qt to rebuild indexes cleanly.Validation
pytest -q tests/test_game_update_crash_fixes.py -k "QuickRefreshGenerationGuard or FileWatcherDebounce"pytest -q tests/test_room_button_rebuild.pyNotes
I could not run the entire
tests/test_game_update_crash_fixes.pyfile on this machine because pytest temp-dir setup/cleanup is hitting a separate Windows permission issue unrelated to this fix.