Skip to content
This repository was archived by the owner on Apr 25, 2026. It is now read-only.

Add filters and room column to mating pair search (#96) - #98

Merged
frankieg33 merged 4 commits into
mainfrom
codex/fix-alive-cats-sort-crash
Apr 23, 2026
Merged

frankieg33 merged 4 commits into
mainfrom
codex/fix-alive-cats-sort-crash

Conversation

@frankieg33

Copy link
Copy Markdown
Owner

Closes #96. See commit message for details.

Preserves table selection and scroll position during quick room
refreshes by emitting layoutAboutToBeChanged + changePersistentIndexList
+ layoutChanged on the source model instead of a full reset. The proxy's
dynamic sort/filter handles re-sorting automatically, so the explicit
proxy invalidate and sortByColumn re-apply in _on_room_patch are no
longer needed.
- Split left bar with vertical splitter: filters on top, cat selector on bottom
- 'Hide cats already in love' toggle hides paired cats from the left list
- Max risk % spinner filters candidate table
- Min quality spinner filters candidate table (Best Pair mode only)
- Trait checklist (mutations + passives + disorders + defects + abilities)
  filters candidates; selected cat's existing traits are bolded with a checkmark
- Search box for the trait list; Reset filters button
- New Room column in both Best Pair and Safe Pair table modes
- Cat list now shows room next to each name

Closes #96
@frankieg33
frankieg33 merged commit 18f5f40 into main Apr 23, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15f1261ec4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +807 to +809
required_muts = self._filter_required_mutations
max_risk = self._filter_max_risk
min_quality = self._filter_min_quality

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply hide-paired filter to partner candidates

When the user enables Hide cats already in love, the candidate table still includes mutual-lover partners because _render_for only applies required_muts, max_risk, and min_quality filters in the candidate loop and never checks _filter_hide_paired. The filter is currently applied only in _refresh_list (left cat selector), which makes the results pane inconsistent with the active filter state and surfaces pairings the user explicitly asked to hide.

Useful? React with 👍 / 👎.

@frankieg33
frankieg33 deleted the codex/fix-alive-cats-sort-crash branch April 23, 2026 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Mating Pair Search Filtering

1 participant