feat: add semantic-release with conventional commits - #212
Merged
Conversation
jleichty-ren
left a comment
There was a problem hiding this comment.
this looks like the same release setup as freckle/cancelable-promise-js#152, so the main concerns were:
- the release config calls
pnpm install && pnpm run build, but the release workflow doesn’t set up pnpm first @semantic-release/gitruns before@semantic-release/npm, so i’m not sure the bumpedpackage.jsonwould get committed back- if we do want to commit back to
main,${{ github.token }}may not be the right token for the repo ruleset - it may be worth adding
"files": ["dist"]before automated publishing
- set up pnpm and node via pnpm/action-setup and actions/setup-node before invoking semantic-release, since the release job otherwise has no pnpm on PATH to run the build - drop the @semantic-release/git step; dist and package.json are no longer committed back to main, since npm packs whatever the build produces on disk via the new "files" allowlist below (avoids the ordering question between the git and npm plugins, and the token/ ruleset question for pushing back to a protected branch) - add "files": ["dist"] to package.json so npm publishes only the built output, matching freckle/cancelable-promise-js
cdmren
force-pushed
the
semantic-release
branch
from
August 20, 2026 21:56
31b0a7f to
4318c0d
Compare
Contributor
|
I'm very unfamiliar with most of this but tried to vibe this to completion because I would like to have tags so we can update this library.
|
jleichty-ren
approved these changes
Aug 21, 2026
jleichty-ren
left a comment
There was a problem hiding this comment.
lgtm, thanks for picking this back up!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.releaserc.yaml) withconventionalcommitspreset, NPM publish, and GitHub release pluginsrelease.ymlworkflow usingcycjimmy/semantic-release-action@v6.0.0rc/*branches for pre-releasesRELEASE.mdwith conventional commit instructionsREADME.mdpnpmfor build command in.releaserc.yaml(matching this repo's package manager)Prerequisites
Before merging, ensure:
NPM_TOKENsecret is configured on the repo for NPM publishingTest plan
.releaserc.yamlandrelease.ymlfeat:commit prefixrc/*branchMirrors freckle/i18n-scripts-js#21