Skip to content

chore(AGLib): ignore restored Lake packages - #3

Merged
AxelDlv00 merged 1 commit into
palimpsest/aglibfrom
palimpsest/contributor/issue-1
Sep 2, 2026
Merged

AxelDlv00 merged 1 commit into
palimpsest/aglibfrom
palimpsest/contributor/issue-1

Conversation

@AxelDlv00

Copy link
Copy Markdown
Collaborator

Contributor : contributor 🧑‍💻 ✅

Profile: contributor (contributor)
GitHub account: @AxelDlv00
Engine: codex
Model: gpt-5.6-sol
Effort: ultra

✅ Summary

  • Ignore AGLib/.lake-packages/, the contributor-tooling dependency staging
    tree that is separate from Lake's normal AGLib/.lake/ directory.
  • Keep restored mathlib sources and generated artifacts out of bootstrap
    worktrees without broadening the package or CI surface.

Merged PR #2 established the requested governance, Lake package, and protected
CI workflow. This final hygiene increment completes the bootstrap issue.

Closes #1

🧪 Local checks

  • git diff --check origin/palimpsest/aglib...HEAD
  • git check-ignore -v --no-index for .lake/, .lake-packages/, .ilean,
    and .olean representatives
  • structured parsing and pin-consistency checks for lakefile.toml,
    lake-manifest.json, and lean-toolchain
  • structured workflow check for the lake-build pull-request/push triggers and
    protected-branch-only bounded cache publication
  • proof-debt scan of the bootstrap Lean files

No Lean file changes in this increment, so new Lean LSP diagnostics are not
applicable. The protected lake-build status remains the authoritative full
package validation.

@AxelDlv00 AxelDlv00 added palimpsest Created or managed by Palimpsest palimpsest/contributor/contributor/running Contributor contributor: Work currently running for this profile palimpsest/reviewer/math-correctness/running Reviewer mathematical-correctness: Review currently running for this profile palimpsest/reviewer/maths-lean-corresp/running Reviewer maths-lean-correspondence: Review currently running for this profile palimpsest/reviewer/lean-quality/running Reviewer lean-quality: Review currently running for this profile palimpsest/reviewer/architecture/running Reviewer architecture: Review currently running for this profile palimpsest/state/validating Waiting for deterministic validation palimpsest/manager/controller/running Palimpsest controller is processing this item labels Sep 2, 2026
@AxelDlv00 AxelDlv00 added palimpsest/manager/controller/waiting-on-ci Palimpsest controller is waiting for required CI statuses palimpsest/manager/controller/running Palimpsest controller is processing this item palimpsest/reviewer/math-correctness/pending Reviewer mathematical-correctness: Review requested from this profile palimpsest/reviewer/maths-lean-corresp/pending Reviewer maths-lean-correspondence: Review requested from this profile palimpsest/reviewer/lean-quality/pending Reviewer lean-quality: Review requested from this profile palimpsest/reviewer/architecture/pending Reviewer architecture: Review requested from this profile palimpsest/state/awaiting-review Waiting for independent reviews palimpsest/manager/controller/pending Palimpsest controller has queued work for this item palimpsest/reviewer/math-correctness/running Reviewer mathematical-correctness: Review currently running for this profile and removed palimpsest/manager/controller/running Palimpsest controller is processing this item palimpsest/manager/controller/waiting-on-ci Palimpsest controller is waiting for required CI statuses palimpsest/reviewer/math-correctness/running Reviewer mathematical-correctness: Review currently running for this profile palimpsest/reviewer/maths-lean-corresp/running Reviewer maths-lean-correspondence: Review currently running for this profile palimpsest/reviewer/lean-quality/running Reviewer lean-quality: Review currently running for this profile palimpsest/reviewer/architecture/running Reviewer architecture: Review currently running for this profile palimpsest/state/validating Waiting for deterministic validation palimpsest/manager/controller/pending Palimpsest controller has queued work for this item palimpsest/reviewer/math-correctness/pending Reviewer mathematical-correctness: Review requested from this profile labels Sep 2, 2026
@AxelDlv00 AxelDlv00 added palimpsest/reviewer/math-correctness/pending Reviewer mathematical-correctness: Review requested from this profile palimpsest/reviewer/maths-lean-corresp/pending Reviewer maths-lean-correspondence: Review requested from this profile palimpsest/reviewer/math-correctness/running Reviewer mathematical-correctness: Review currently running for this profile palimpsest/reviewer/maths-lean-corresp/running Reviewer maths-lean-correspondence: Review currently running for this profile and removed palimpsest/reviewer/math-correctness/running Reviewer mathematical-correctness: Review currently running for this profile palimpsest/reviewer/maths-lean-corresp/running Reviewer maths-lean-correspondence: Review currently running for this profile palimpsest/reviewer/math-correctness/pending Reviewer mathematical-correctness: Review requested from this profile palimpsest/reviewer/maths-lean-corresp/pending Reviewer maths-lean-correspondence: Review requested from this profile labels Sep 2, 2026
@AxelDlv00

Copy link
Copy Markdown
Collaborator Author

Reviewer : maths-lean-correspondence 🌉 ✅

Profile: maths-lean-correspondence (reviewer)
GitHub account: @AxelDlv00
Engine: codex
Model: gpt-5.6-sol
Effort: ultra
Decision: approved ✅
Head: c66ffd7

🔍 Coverage

Reviewed exact head c66ffd7c90c36afae7897f561e62c81c8c9ad684 against the supplied PR description, review.json, changes.diff, and both changed-file snapshots. The complete delta is the single rule AGLib/.lake-packages/ at .gitignore:3; there are no changed Lean files, public declarations, logical helpers, proofs, imports, instances, coercions, or docstrings to inventory. This matches the stated final bootstrap-hygiene boundary and introduces no undisclosed mathematical API.

The live forge issue/comment lookup was unavailable because the adapter's configured credential mount is absent, so issue reconciliation is limited to the immutable job metadata and supplied PR body. That leaves no unresolved maths–Lean question for this patch: its changed declaration inventory is empty.

✅ Verified

  • The description distinguishes contributor-tooling staging at AGLib/.lake-packages/ from Lake's normal package state. The exact-head AGLib/lake-manifest.json sets packagesDir to .lake/packages, and .github/workflows/lean-ci.yml likewise uses AGLib/.lake/packages and AGLib/.lake/build; the new hyphenated rule does not alter either path.
  • Direct git check-ignore -v --no-index probes resolve a staged dependency file and nested Git metadata to .gitignore:3. The same probes leave AGLib/AGLib/Basic.lean and AGLib/.lake-packages-backup/example unignored. Thus the rule expresses the claimed directory boundary rather than a broader source exclusion.
  • Since the exact diff changes no Lean text, all existing definition identities, theorem statements, hypotheses, implicit/typeclass content, proof meanings, and declaration docstrings remain byte-for-byte outside the delta. There is consequently no new opportunity for weakening, vacuity, wrong-direction implication, or prose/statement mismatch in this review dimension.

🧪 Validation

  • Compared base/.gitignore, head/.gitignore, and changes.diff; they agree on the sole added line.
  • Confirmed the protected workflow still targets palimpsest/aglib and runs lake build AGLib. The immutable context did not provide a CI-result artifact, so this review does not claim a green run.
  • Per /tmp/palimpsest-documentation/pr-review.md, I did not start Lean LSP, run Lake, or download caches. Those checks are unnecessary for this non-Lean metadata delta. A mathlib precedent search is likewise not applicable to this routine maintenance change.

💬 Decision

✅ Approve for maths–Lean correspondence. The exact head changes no mathematical or Lean claim, and the sole ignore rule faithfully implements the directory distinction described by the PR.

@AxelDlv00

Copy link
Copy Markdown
Collaborator Author

Reviewer : mathematical-correctness 📐 ✅

Profile: mathematical-correctness (reviewer)
GitHub account: @AxelDlv00
Engine: codex
Model: gpt-5.6-sol
Effort: ultra
Decision: approved ✅
Head: c66ffd7

🔍 Coverage

I reviewed exact head c66ffd7c90c36afae7897f561e62c81c8c9ad684 against base
585c690fec0889def2d18291a6ce43290a39186b. The supplied PR description scopes
this increment to ignoring the restored Lake dependency-staging tree, and the
complete changes.diff plus review.json agree: the only changed file is
.gitignore, with the single addition AGLib/.lake-packages/.

The mathematical inventory is therefore empty: no public or private Lean
declaration, theorem statement, hypothesis, proof, import, dependency pin, or
downstream mathematical API changes at this head. There are no undisclosed
mathematical additions and no mathematical acceptance item omitted by this
delta.

✅ Verified

  • The head snapshot source/.gitignore is byte-identical to head/.gitignore.
  • git apply --numstat changes.diff reports one insertion and zero deletions in
    .gitignore.
  • The new ignore rule is repository metadata only. It cannot strengthen or
    weaken a proposition, introduce a vacuous case, alter a proof mechanism, or
    affect the logical environment seen by existing Lean sources.

🧪 Validation

No LSP or Lake command was run: this read-only reviewer job disables both, and
there is no Lean delta requiring elaboration evidence. I also verified that the
exact-head tree retains the protected-branch lake-build workflow; I do not
infer an Actions result from its presence.

🟡 Live issue, PR-list, comment, and CI-status queries through
palimpsest-forge were unavailable because the controller-owned forge gateway
reported its configured credential file missing. This limits forge-record
reconciliation, but it does not leave a mathematical uncertainty in this
one-line metadata-only patch.

The scope and exact-head reasoning follow
$PALIMPSEST_DOCUMENTATION/pr-review.md; routine maintenance does not call for
a mathlib PR precedent search under
$PALIMPSEST_DOCUMENTATION/mathlib-reviewing.md.

💬 Decision

✅ Approve for mathematical correctness. There are no mathematical findings
at this exact head.

@AxelDlv00

Copy link
Copy Markdown
Collaborator Author

Reviewer : lean-quality 🧪 ✅

Profile: lean-quality (reviewer)
GitHub account: @AxelDlv00
Engine: codex
Model: gpt-5.6-sol
Effort: ultra
Decision: approved ✅
Head: c66ffd7

🔍 Coverage

Reviewed exact head c66ffd7c90c36afae7897f561e62c81c8c9ad684 against base 585c690fec0889def2d18291a6ce43290a39186b, reconciling the supplied issue/PR scope with the immutable diff and changed-file snapshots. The intended boundary is the final bootstrap hygiene increment: ignore the contributor-tooling dependency staging tree at AGLib/.lake-packages/ without changing AGLib's normal Lake layout or CI surface.

The exact patch adds only .gitignore:3. It changes no Lean declarations or helpers, imports, docstrings, proofs, dependency pins, package configuration, or workflow configuration.

✅ Verified

  • Git's own check-ignore -v --no-index attributes both AGLib/.lake-packages and a nested dependency path to the new line. Representative near misses (AGLib/.lake-packages-file and nested/AGLib/.lake-packages/...) remain unignored, so the rule is not broader than the named package-local staging directory.
  • The staging target is presented as a real directory by the contributor tooling's read-only bind mount, so the trailing slash matches the actual artifact form. Existing rules continue to cover AGLib/.lake/, *.ilean, and *.olean independently.
  • AGLib/lake-manifest.json still selects .lake/packages, and the unchanged CI workflow still caches AGLib/.lake/packages and AGLib/.lake/build before running lake build AGLib. The new rule neither redirects nor expands those Lake/CI paths.
  • head/.gitignore is byte-identical to source/.gitignore; the supplied diff contains no whitespace defect.

🧪 Validation

  • I did not start Lean LSP or Lake: no Lean file changed, and reviewer-local builds are prohibited by $PALIMPSEST_DOCUMENTATION/pr-review.md. The protected lake-build status remains the authoritative full-package check; changed-file timing is not applicable here.
  • This is routine non-Lean maintenance, so the same review guide's mathlib-PR analogue search requirement does not apply.
  • 🟡 The configured forge reader could not refresh issue/comment listings because its controller credential file is unavailable in this session. Coverage therefore uses the controller-supplied PR metadata and immutable exact-head artifacts; this leaves no material lean-quality uncertainty for this one-line path rule.

💬 Decision

Approve. I found no blocking or non-blocking lean-quality issue at this exact head. The change is focused, correctly scoped, and preserves the package and CI boundaries it claims to leave unchanged.

@AxelDlv00

Copy link
Copy Markdown
Collaborator Author

Reviewer : architecture 🏗️ ✅

Profile: architecture (architecture)
GitHub account: @AxelDlv00
Engine: codex
Model: gpt-5.6-sol
Effort: ultra
Decision: approved ✅
Head: c66ffd7

🔍 Coverage

Reviewed exact head c66ffd7c90c36afae7897f561e62c81c8c9ad684 against base
585c690fec0889def2d18291a6ce43290a39186b, the live issue and PR records,
the complete changes.diff, both changed-file snapshots, and the exact-head
source tree.

Issue #1 names the governance, Lake package, minimal public import, README, and
protected CI workflow as the bootstrap acceptance surface. The base is the merge
of PR #2 and retains all of those artifacts. This PR adds only
AGLib/.lake-packages/ at .gitignore:3; it changes no Lean declaration or
helper, module import, dependency pin, package setting, workflow setting,
bibliography entry, or roadmap node. There are no undisclosed additions or
missing architectural deliverables in this delta. The intended unchanged
boundary is AGLib's public API and dependency DAG.

✅ Verified

  • The restoration directory is real in the supplied context and contains
    mathlib plus its transitive package source/build trees. Git's own
    check-ignore -v --no-index attributes both the directory and a nested
    Mathlib.lean path to .gitignore:3.
  • The rule is project-scoped and exact. Probes for
    AGLib/.lake-packages-backup/... and
    nested/AGLib/.lake-packages/... remain visible, as does
    AGLib/AGLib/Basic.lean; the change cannot hide a sibling repository area or
    an ordinary AGLib module.
  • AGLib/lake-manifest.json:3 still declares Lake's canonical package location
    as .lake/packages. The unchanged workflow restores
    AGLib/.lake/packages and AGLib/.lake/build at
    .github/workflows/lean-ci.yml:71 and :79, then builds AGLib at :95.
    The hyphenated staging directory is not introduced into Lake or CI, so the
    ignore rule cannot become a second dependency mechanism.
  • This preserves the accepted AGLib/ROADMAP.md boundary: mathlib remains the
    only Lean dependency (:10), modules retain their downward-only import rule
    (:32), and no flagship/source tree is made a dependency. The bootstrap
    import remains only Mathlib.AlgebraicGeometry.Scheme at
    AGLib/AGLib/Basic.lean:8.

🟡 Scope Caveat

Issue #1 requested the bootstrap as one PR, whereas this is a second corrective
PR after PR #2 merged. That is a historical process deviation, but not a defect
that can be repaired at this exact head. The follow-up is cohesive, contains
only repository hygiene needed to keep restored dependencies out of source, and
does not broaden or falsely advance the roadmap. No roadmap, Lake, or module
change should be added to compensate for the split.

🧪 Validation

  • review.json, the live PR record, and PALIMPSEST_EXPECTED_HEAD agree on the
    reviewed head; source/.gitignore is byte-identical to head/.gitignore.
  • The base/head comparison contains one insertion, and the no-index diff check
    reports no whitespace error.
  • The forge record carries palimpsest/state/awaiting-review, and
    /tmp/palimpsest-documentation/workflow.md places reviewer dispatch after
    exact-head Actions validation. No raw Actions result or log is mounted here,
    so I do not independently restate a CI conclusion.
  • Per /tmp/palimpsest-documentation/pr-review.md, I did not start LSP, run
    Lake, update dependencies, or download caches. This routine metadata-only
    patch introduces no public Lean API or non-obvious design choice requiring a
    mathlib PR analogue, and it makes no publication-backed mathematical claim.

💬 Decision

✅ Approve for architecture. The exact change closes a narrow bootstrap hygiene
gap while preserving the accepted roadmap, canonical Lake layout, CI surface,
module graph, and downstream API.

@AxelDlv00

Copy link
Copy Markdown
Collaborator Author

Maintainer : maintainer-adviser 🧭 ✅

Profile: maintainer-adviser (maintainer,contributor)
GitHub account: @AxelDlv00
Engine: codex
Model: gpt-5.6-sol
Effort: ultra
Head: c66ffd7

🔀 Merge result

✅ Squash-merged assigned head
c66ffd7c90c36afae7897f561e62c81c8c9ad684 into palimpsest/aglib as
1a9309add587bf521afe977d0d142d1f94300b97.

✅ Accepted gates

  • The controller reported the required lake-build status successful and
    merge_ready: true for the accepted head.
  • mathematical-correctness, maths-lean-correspondence, lean-quality, and
    architecture all approved that exact head.
  • The focused one-line .gitignore delta passed diff hygiene and path-boundary
    checks while leaving AGLib's Lean API, canonical Lake paths, CI surface, and
    roadmap unchanged.

PR #2 plus this final hygiene increment complete the acceptance criteria of
issue #1. The PR now reports merged; issue #1 should be closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

palimpsest/maintainer/maint-adviser/ok Maintainer maintainer-adviser: This profile completed the requested work palimpsest/manager/controller/ok Palimpsest controller completed this item palimpsest/reviewer/architecture/ok Reviewer architecture: This profile approved the current head palimpsest/reviewer/lean-quality/ok Reviewer lean-quality: This profile approved the current head palimpsest/reviewer/math-correctness/ok Reviewer mathematical-correctness: This profile approved the current head palimpsest/reviewer/maths-lean-corresp/ok Reviewer maths-lean-correspondence: This profile approved the current head palimpsest/state/merged Merged; work complete palimpsest Created or managed by Palimpsest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant