ci(windows): glob libsecp256k1-*.dll copies to survive upstream SONAME bumps - #1069
Open
frstrtr wants to merge 1 commit into
Open
ci(windows): glob libsecp256k1-*.dll copies to survive upstream SONAME bumps#1069frstrtr wants to merge 1 commit into
frstrtr wants to merge 1 commit into
Conversation
…E bumps build.yml and release.yml hardcoded Copy-Item of libsecp256k1-6.dll in the Windows x86_64 Verify/Smoke and Package steps. The secp256k1 clone is unpinned at upstream HEAD, which bumped the shared-lib SONAME 6 -> 7, so the runner emits libsecp256k1-7.dll and every copy fails with Cannot find path -> exit 1, breaking Windows x86_64 identically on master and all open PRs. Generalize all six copies to a libsecp256k1-*.dll glob so any future SONAME bump copies whatever the build produced. This is the Windows recurrence of the libsecp256k1.so.2-vs-.so.1 DOA release.yml:223 flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows x86_64 is broken repo-wide (master + every open PR), not a flake. The secp256k1 clone (build.yml:1175 / release.yml:599) is
git clone --depth 1at upstream HEAD; upstream bumped the shared-lib SONAME 6 -> 7, so the runner now emitslibsecp256k1-7.dll. The Verify/Smoke and Package steps hardcodeCopy-Item .../libsecp256k1-6.dll, which no longer exists ->Cannot find path-> exit 1. Same three copies in each of build.yml and release.yml.Fix (option b — SONAME-agnostic)
Generalize all six copies to a
libsecp256k1-*.dllglob so a future SONAME bump copies whatever the build produced, and add a comment forbidding re-pinning a number. Closes the recurrence class release.yml:223 already flags for the Linux.so.2-vs-.so.1DOA — now on Windows.Acceptance
Master Windows x86_64 job green; both files free of a hardcoded SONAME. Unblocks dgb-scrypt-steward #1067 (green on merits, red only on this).