Improve RSCP frame reception handling to ensure complete frames are processed - #145
Closed
torbennehmer wants to merge 2 commits into
Closed
Improve RSCP frame reception handling to ensure complete frames are processed#145torbennehmer wants to merge 2 commits into
torbennehmer wants to merge 2 commits into
Conversation
5 tasks
Contributor
Author
|
#146 looks like the more stable solution to me. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag EH_REQ_GET_SAVED_ERRORS returns a large amount of data (approx 4k on my end), which gets split by TCP in multiple chunks.
Sample code:
This yields:
Altering the receive call to a loop fixes the problem, it assembles the frame appropriately. Tested various other calls to ensure correct functionality.
Prerequisite for hacs-e3dc PR torbennehmer/hacs-e3dc#373