Eliminate warnings in gif-only builds - #285
Open
mhoev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate the compiler warnings produced by this reduced-feature build:
cargo check --no-default-features --features gifRoot cause
With default features disabled,
gifenables theimagesfeature but does notenable
htmlortext_layout. Several imports, helpers, and parameters weretherefore compiled in configurations where their consumers were absent.
Two closure bindings were also marked mutable even though the closures do not
mutate their captured state.
Together, these produced 11 unused-code and unnecessary-
mutwarnings.Changes
Opimport and Type 1 font helper ontext_layout.html.imagesis disabled, matchingits existing call site.
underscores, while preserving their use in feature-enabled builds.
mutqualifiers.No warning lints are suppressed, public signatures are unchanged, and runtime
behavior is preserved.
Verification
All Cargo commands were run with
RUSTFLAGS="-D warnings":git diff --checkalso passes.