Skip to content

Fix none nollning group test fails - #556

Open
hannesblaman wants to merge 2 commits into
mainfrom
fix_none_group_tests
Open

Fix none nollning group test fails#556
hannesblaman wants to merge 2 commits into
mainfrom
fix_none_group_tests

Conversation

@hannesblaman

Copy link
Copy Markdown
Contributor

Updated one test, added one test and fixed the event signup code to pass the last test

@hannesblaman
hannesblaman marked this pull request as ready for review August 7, 2026 15:51
@hannesblaman hannesblaman self-assigned this Aug 7, 2026
@georgelgeback

Copy link
Copy Markdown
Contributor

Do we want to allow someone to:

  1. Sign up to a nollning event with a certain group
  2. Edit their signup so that they don't have any group associated with the sign up

Allowing this (as we currently do, see: test_update_signup_without_group_name_is_allowed) does conflict a bit with the test_nollning_event_signup_without_group test, since you can achieve a different end state by editing the signup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants