Repository navigation
ext-tool join: fail loudly when SCRIPT_DIR is unset - #1730
Merged
Merged
Conversation
The driver-registry source added for plugin-sourced ext-tools read
SCRIPT_DIR with no guard, which put check-unguarded-env-reads one over
its baseline (61/60) once the branch sat on 1.6.0. Use ${SCRIPT_DIR:?}
so a missing value stops with a named error instead of a bare set -u
abort, and the count is back at the baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of 1.6.0,
check-unguarded-env-readscounts 61 against a baseline of 60. The new row is the driver-registry source inscripts/drivers/types/ext-tool/_join.sh, added for plugin-sourced ext-tools (#1700).This reads it as
${SCRIPT_DIR:?}, so a missing value stops with a named error rather than a bareset -uabort.Verified:
.github/scripts/check-unguarded-env-reads.sh: 60, at the baselinetests/test_unguarded_env_reads.batsand the ext-tool suites: 365/365