Skip to content

feat(Combobox): add themeResetClass for the portalled menu (MET-3088) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zayooo00 merged 1 commit into from
Sep 1, 2026
Merged

feat(Combobox): add themeResetClass for the portalled menu (MET-3088) #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/code-components/Combobox/Combobox.register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export function registerCombobox(
description:
"'input' matches the input width; 'fit' grows to the widest option (long labels don't wrap), never narrower than the input, capped to stay on screen.",
},
themeResetClass: { type: "themeResetClass" },
"aria-label": "string",
"aria-labelledby": "string",
placeholder: { type: "string", defaultValue: "Select" },
Expand Down
17 changes: 16 additions & 1 deletion src/code-components/Combobox/Combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ interface ComboboxProps {
* menu is still kept inside the viewport by Floating UI.
*/
menuWidth?: "input" | "fit";
/**
* Plasmic's theme-reset class. In prod the menu is portalled to
* `document.body`, outside the element that carries Plasmic's design-token
* CSS variables, so `var(--token-*)` in the menu's styles stops resolving and
* it renders unstyled. Registered as `type: "themeResetClass"` so Plasmic
* supplies the class automatically; it is applied to the portalled root. No
* effect in the Plasmic canvas, where the menu already renders inline.
*/
themeResetClass?: string;
"aria-label"?: string;
"aria-labelledby"?: string;
placeholder?: string;
Expand Down Expand Up @@ -102,6 +111,7 @@ export function Combobox({
disabled,
menuPlacement = "bottom start",
menuWidth = "input",
themeResetClass,
"aria-label": ariaLabel,
"aria-labelledby": ariaLabelledBy,
placeholder,
Expand Down Expand Up @@ -245,7 +255,12 @@ export function Combobox({
anchor: { to: menuPlacement, gap: 1, padding: 8 },
transition: true,
})}
className={styles.positioner}
// `themeResetClass` re-establishes Plasmic's design-token CSS
// variables on the portalled root so `var(--token-*)` in the
// menu's styles still resolves.
className={[styles.positioner, themeResetClass]
.filter(Boolean)
.join(" ")}
>
{/*
* Inner wrapper carries all sizing + look. Headless UI's `anchor`
Expand Down
Loading