Skip to content

[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 3.0.132 - #397

Closed
dnyw4l3n13 wants to merge 5 commits into
mainfrom
depends/update-meziantou.analyzer/3.0.132
Closed

[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 3.0.132#397
dnyw4l3n13 wants to merge 5 commits into
mainfrom
depends/update-meziantou.analyzer/3.0.132

Conversation

@dnyw4l3n13

@dnyw4l3n13 dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Removed no-longer used code

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • I have added tests to cover my changes.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.
  • No user-controlled or step-output value is string-interpolated directly into a run:/script: body (workflow or composite action); pass it via step-level env: and reference $VAR (bash) or process.env.VAR (github-script) instead.

@dnyw4l3n13 dnyw4l3n13 added the auto-pr Pull request created automatically label Jul 28, 2026
@dnyw4l3n13 dnyw4l3n13 self-assigned this Jul 28, 2026
@dnyw4l3n13
dnyw4l3n13 force-pushed the depends/update-meziantou.analyzer/3.0.132 branch from f6c52a6 to 5b54c66 Compare July 28, 2026 05:25
@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed in 7794fc8 - added StringComparer.Ordinal to Assert.Contains calls in CloudFormationSnsPropertiesParserTests.cs to satisfy Meziantou.Analyzer MA0002 (raised by the 3.0.132 bump in this PR), which was failing build-pre-release. Board set to Development.

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Simplify clean - advancing to code review

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Code review clean - advancing to security review

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Security review clean, advancing to coverage check

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Coverage ratchet passed - advancing to Human Review

@dnyw4l3n13
dnyw4l3n13 marked this pull request as ready for review July 28, 2026 09:19
@dnyw4l3n13
dnyw4l3n13 requested a review from a team as a code owner July 28, 2026 09:19
@dnyw4l3n13
dnyw4l3n13 enabled auto-merge July 28, 2026 09:19
@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

PR marked ready for review (was draft) and auto-merge enabled. Ready to merge once branch protection requirements are satisfied.

@credfeto

credfeto commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed in fec547f - added the missing ### Deprecated section to CHANGELOG.md's [Unreleased] block (via Credfeto.ChangeLog.Cmd --lint --fix) to satisfy the valid-changelog check, which was failing. Board set to Development.

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed in 3f3710f - reverted the changelog reformatting outside the Unreleased section (Keep a Changelog header addition and dash-format changes to the [1.2.0]/[1.1.0]/[1.0.0] release headers) that the previous --lint --fix run in fec547f introduced; this was tripping the change-log-entry-is-in-unreleased check, which disallows edits to already-released sections. Board set to Development.

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Simplify clean - advancing to code review

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Code review clean - advancing to security review

@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Security review clean, advancing to coverage check

@dnyw4l3n13 dnyw4l3n13 added the Blocked Blocked by a dependency or external factor label Jul 28, 2026
@dnyw4l3n13

dnyw4l3n13 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

GitHub reports this PR as BLOCKED (mergeStateStatus) with auto-merge enabled, but no required check is failed or pending — most likely a required status check that has never reported any result at all. The automation's idle-invocation budget (5) is exhausted without further progress. Blocking this PR until a human investigates the repository's required status checks.

@credfeto

credfeto commented Jul 29, 2026

Copy link
Copy Markdown
Member

Un-blocking: the escalation above was based on the orchestrator's own automation misreading GitHub's mergeStateStatus: BLOCKED as a signal that this PR needed a human - it doesn't; that field reflects GitHub's own merge-readiness computation (e.g. a required check that simply hasn't posted a status yet), not a problem with this PR. That behaviour has been reverted (credfeto/credfeto-orchestrator#1266, PR credfeto/credfeto-orchestrator#1267).

@credfeto credfeto removed the Blocked Blocked by a dependency or external factor label Jul 29, 2026
credfeto and others added 5 commits July 29, 2026 10:45
@credfeto @dnyw4l3n13
[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 3.0.132
4708bfd
@dnyw4l3n13
[Fix] Use ordinal comparer for string collection Contains assertions
40e14a1 
Meziantou.Analyzer 3.0.132 (MA0002) flags Assert.Contains overloads on
string collections that don't specify a comparer.
@dnyw4l3n13
[Coverage] Add COVERAGE.md baseline (bootstrap)
0fe245b 
First AI Coverage phase run for this branch; origin/main has no
COVERAGE.md yet, so this establishes the initial baseline.
@dnyw4l3n13
[Fix] Add missing Deprecated section to CHANGELOG.md Unreleased block
3d733eb 
valid-changelog CI check failed lint: "Missing required section '### Deprecated' in [Unreleased]". Fixed using the Credfeto.ChangeLog.Cmd --lint --fix tool per project convention (never hand-edit CHANGELOG.md).
@dnyw4l3n13
[Fix] Revert unintended changelog reformatting outside Unreleased sec…
c65fa66 
…tion

Credfeto.ChangeLog.Cmd --lint --fix rewrote the Keep a Changelog header
and historical release headers, which fails the change-log-entry-is-in-unreleased
check that requires edits confined to the Unreleased section.
@dnyw4l3n13
dnyw4l3n13 force-pushed the depends/update-meziantou.analyzer/3.0.132 branch from 3f3710f to c65fa66 Compare July 29, 2026 09:45
@credfeto credfeto closed this Jul 29, 2026
auto-merge was automatically disabled July 29, 2026 18:44

Pull request was closed

@credfeto
credfeto deleted the depends/update-meziantou.analyzer/3.0.132 branch July 29, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@credfeto credfeto

@dnyw4l3n13 dnyw4l3n13

Labels

auto-pr Pull request created automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnyw4l3n13 @credfeto