ci: make PR checks fork-safe by dropping the unused chat-widget fetch - #824
Merged
Conversation
- @futureagi/chat-widget is imported nowhere in the source and absent from package-lock.json; remove the vestigial workspace dependency - pr-checks: the audit scripts use only Node built-ins, so drop the private-repo clone, the dependency patch and npm install entirely. Fork PRs never receive repo secrets, which is why every external contribution failed this check at the clone step - deploy: drop the now-inert fetch and patch steps, removing the workflow's last dependence on the GH_PAT secret Signed-off-by: khushalsonawat <khushalsonawat@gmail.com>
atharva-bhange
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
@futureagi/chat-widgetfetch from CI and the vestigial dependency from package.json. The link-audit job now runs on bare Node with no secrets and no install; deploy loses two inert steps.Why
PR #822 (an external contribution) failed the link audit before any checking ran: the job clones the private landing-page repo using
secrets.GH_PAT, and GitHub withholds repository secrets from fork-PR runs, so the clone fails with exit 128. Every future external PR would fail the same way.What cases were covered
@futureagi/chat-widgetis imported nowhere in src, astro config, or plugins; package-lock.json contains zero references to it. AiChatWidget.astro is self-contained and talks to the docs-agent service over HTTPaudit-links.mjs,check-deleted-pages.mjs) import only Node built-ins (fs, path, child_process, url); ran both locally on a clean tree, both exit 0 with no node_modules involvementnpm installfor the real build dependencies; only the fetch and patch steps are removedHow
Deleted the fetch/patch/cache/install steps from pr-checks.yml, the fetch/patch steps from deploy.yml, and the workspace dependency line from package.json.
Recording
Not applicable: CI-only change. Proof is #822's check going green on rerun once this merges.
🤖 Generated with Claude Code