Preserve ribbon colour when Dark Reader is active - #16
Merged
Merged
Conversation
Dark Reader injects its own !important stylesheet after the extension's content stylesheet, which lets it win when both rules have equal specificity. guardRibbon() now sets background-color, background-image and color as inline styles with !important directly on the ribbon band element — inline important beats any stylesheet rule regardless of load order. A MutationObserver watches the band's style attribute and reapplies immediately if Dark Reader (or any other extension) overrides the values, using disconnect-before-paint-reconnect to avoid infinite callbacks. releaseRibbon() disconnects the guard and removes the three inline properties so BC's original styling is restored cleanly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark Reader injects its own !important stylesheet after the extension's content stylesheet, which lets it win when both rules have equal specificity.
guardRibbon() now sets background-color, background-image and color as inline styles with !important directly on the ribbon band element — inline important beats any stylesheet rule regardless of load order. A MutationObserver watches the band's style attribute and reapplies immediately if Dark Reader (or any other extension) overrides the values, using disconnect-before-paint-reconnect to avoid infinite callbacks.
releaseRibbon() disconnects the guard and removes the three inline properties so BC's original styling is restored cleanly.