fix(gen-zig): invariant marker as comment; pin untyped literal-init mutables to u32 - #1931
Merged
Merged
Conversation
…utables to u32 Closes #1930 Two emission classes measured on the tri-net corpus (21 specs blocked): - Empty invariant blocks emitted @compilelog(...), which zig test treats as a hard error ("found compile log statement") -- every spec with an empty invariant block failed before a single test ran. The marker is now a plain comment. - Untyped mutable locals initialized with a bare integer literal emitted `var x = 0xFF;` (comptime_int, rejected for var). The declaration now pins the default integer width: u32, or u64 when the literal does not fit u32. tri-net corpus verification: both error classes gone (8 + 13 specs); 7 specs newly pass zig test end-to-end, 14 advance to their runtime layer. FROZEN_HASH resealed. bitnet_layer iverilog test is pre-existing red on master (unrelated, Verilog path untouched). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 11:16
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1930
Two Zig emission classes from the #1928 ledger, measured on the tri-net corpus (21 specs blocked):
@compileLog(...)—zig testtreats any compile log statement as a hard error, so affected specs failed before one test ran. Marker is now a plain comment.var x = 0xFF;(comptime_int, rejected forvar). Declarations now pin the default width:u32, oru64when the literal exceeds u32.Verification on the tri-net corpus: both error classes gone (8 + 13 specs); 7 specs newly pass
zig testend-to-end, 14 advance to their runtime layer (tracked tri-net-side). Unit suite: only pre-existing red isbitnet_layer(iverilog elaboration, fails on pristine master; Verilog path untouched here). FROZEN_HASH resealed; NOW.md entries added.🤖 Generated with Claude Code