fix(gen-verilog): imported structs resolve field part-selects; mac declares its phantom TernaryWord - #2401
Merged
Merged
Conversation
…clares its phantom TernaryWord Two halves of the word_raw defect (#2275): (1) struct_decls held only module-local structs, so a field access on an imported-struct param fell past the part-select branch and flattened to an unbound identifier -- use_resolve::imported_structs now mirrors the imported-enums pass and merges every direct dependency's struct decls without shadowing local ones; (2) the deeper find: NO file in the corpus declares TernaryWord{raw} -- base::ternary_memory's struct of that name is a different shape -- so mac.t27 referenced a phantom type. The spec now declares its own single-field struct; word.raw lowers to word[0 +: 32], parse/typecheck clean, 32/32 yosys smoke. The mac_units array-of-structs half stays open in #2275 as an emitter feature. M5 performed. Two failing verilog unit tests reproduce identically on clean master (pre-existing). Refs #2275.
gHashTag
enabled auto-merge (squash)
August 22, 2026 10:48
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-22 10:48:48 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2275. Half one of the mac elaboration defect: imported-struct registry (mirrors imported-enums, local always wins) + the phantom-type finding and its local declaration. word.raw -> word[0 +: 32]; 32/32 yosys; docs/now entry per the new mechanism.
🤖 Generated with Claude Code