tri now add: --refs cites an issue without closing it (Refs #141) - #2649
Merged
Conversation
`--closes N` stamps "(Closes #N)", and GitHub acts on that word. LOOP-RULES R11 bans autoclosing a long-lived tracking issue, so an entry that had to cite one could only autoclose it (banned), hand-edit the generated file (the drift this command exists to prevent), or cite nothing. All three were taken at least once. `--refs N` stamps "(Refs #N)": the citation without the side effect. It conflicts_with "closes" -- an entry carrying both says two different things about one issue, and clap refuses it for free (verified: exit 2, no file written). The suffix moves into `issue_suffix()`, separate from the writer so it is testable without a filesystem. `Closes` and `Refs` differ by nothing a reviewer reliably notices in a diff, and only one of them closes an issue.
Contributor
PR DashboardGenerated at: 2026-08-24 02:19:33 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-24 02:32:01 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tri now addhad exactly one issue flag:--closes N, stamping(Closes #N)— and GitHub acts on that word.LOOP-RULES R11 bans autoclosing a long-lived tracking issue. So an entry that had to cite one had three options, all bad:
--closesAll three were taken at least once, including by me, twice in this campaign.
--refs Nstamps(Refs #N): the citation without the side effect.Measured, not asserted
conflicts_with = "closes"— verified by running it: exit 2, no file written. Declaring a conflict and enforcing one are different claims.issue_suffix(), separate from the writer, so it is testable without a filesystem. Two tests:Refsmust not contain the stringCloses, and--closesmust still autoclose.ClosesandRefsdiffer by nothing a reviewer reliably notices in a diff, and only one of them closes an issue — so the test asserts the absence of the dangerous word, not just the presence of the right one.Self-demonstrating
This PR's own NOW entry is the flag's first use, citing #141 — the now-coordination anchor, which must never be autoclosed. Before this change, writing that entry correctly was not possible with the command.
Refs #141