fix(ci): run the desktop build step under bash on Windows runners - #22
Merged
Merged
Conversation
Windows runners default to PowerShell, so the build-info stamping added in #21 failed to parse and both Windows desktop jobs died before wails ran. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
elek review: encountered an issue Elek could not complete this review run. See the workflow logs for details. Estimated review cost: $0.0024 (5,455 in / 0 out tokens) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.4.1 release build failed on both Windows desktop jobs:
Windows runners default to PowerShell, and the build-info stamping added in #21 is written in bash. Pinning
shell: bashon that step keeps one syntax across all five desktop jobs; bash ships with the Windows runner image.The macOS and Linux desktop jobs and the CLI build all succeeded, so this only affects the two Windows targets.
🤖 Generated with Claude Code