chore: synchronize workspace version to 0.3.3 and protocol to 0.2.5 - #8
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a wasm asset registry with Changes
Sequence Diagram(s)sequenceDiagram
participant GameWorker as Game Worker
participant AetherisClient as Aetheris Client
participant AssetRegistry as Asset Registry
participant HTTP as HTTP Fetch
participant Parser as Asset Parser
participant MeshStore as DashMap Storage
GameWorker->>AetherisClient: wasm_load_asset(handle, url)
AetherisClient->>AssetRegistry: load_asset(handle, url)
AssetRegistry->>HTTP: fetch(url)
HTTP-->>AssetRegistry: Vec<u8>
AssetRegistry->>Parser: parse_asset(bytes)
Note over Parser: Validate AEB_MAGIC<br/>Check version (0)<br/>Decompress Zstd payload<br/>Deserialize with rmp_serde
Parser-->>AssetRegistry: MeshData
AssetRegistry->>MeshStore: insert(handle, mesh)
AssetRegistry-->>AetherisClient: Result<(), JsValue>
AetherisClient-->>GameWorker: Result<(), JsValue]
sequenceDiagram
participant GameWorker as Game Worker
participant Client as Aetheris Client
participant Transport as GameTransport
participant Server as Server
participant ReconnectFn as attemptReconnection()
GameWorker->>Client: tick()
Client->>Transport: poll_events()
Transport-->>Client: NetworkEvent::Disconnected
Client->>Client: set connection_state = Disconnected
GameWorker->>ReconnectFn: (on disconnected)
ReconnectFn->>ReconnectFn: calc exponential backoff + jitter
ReconnectFn->>GameWorker: postMessage({type:'reconnecting'})
ReconnectFn->>Client: reconnect(url, cert_hash)
Client->>Transport: connect(url, cert_hash)
Transport->>Server: establish connection
alt success
Server-->>Transport: connected
Transport-->>Client: connection ready
ReconnectFn->>GameWorker: postMessage({type:'connection_ready'})
else failure
Transport-->>Client: error
ReconnectFn->>ReconnectFn: schedule retry
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronizes the client workspace version and protocol dependencies to match the latest engine and protocol releases.
Summary by CodeRabbit
New Features
Documentation
Chores
Style