Repository navigation
fix(nodejs): a prefix-less ~/.npmrc no longer aborts the module - #49
Merged
Merged
Conversation
_ensure_npm_prefix read the current prefix with grep | tail | sed inside $(); with no prefix line grep exits 1 and pipefail + errexit killed the script silently (seen on grace, whose .npmrc holds only an auth token). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S29GMkRB43pGsAUBUXwLdT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On grace, the Track 8 rollout failed with
nodejs: install.sh failed: exit status 1and printed no other output._ensure_npm_prefixreads the current prefix withgrep | tail | sedinside$(). When~/.npmrcexists but has noprefix=line (grace's holds only an auth token), grep exits 1, and pipefail plus errexit kill the script. That's exactly the case the function exists to fix.|| trueon the read.~/.npmrcbefore the nodejs/mise install, and assert the other lines are kept. Without the fix: 7 failures. With it: ubuntu 77/77.🤖 Generated with Claude Code
https://claude.ai/code/session_01S29GMkRB43pGsAUBUXwLdT