Repository navigation
fix(mise): login shells put the shims first, not merely on PATH - #50
Merged
Merged
Conversation
The stock Ubuntu ~/.profile sources ~/.bashrc (whose mise block adds the shims) and then prepends ~/.local/bin; the ~/.profile block only added the shims when absent, so stale ~/.local/bin copies (the tarball node, an old starship) won in every login shell. Found by the nodejs provider=mise canary on hal: nodejs verify failed with login node = ~/.local/bin/node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S29GMkRB43pGsAUBUXwLdT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the Track 8 Phase 6 node canary (
nodejs.provider: miseon hal). nodejsverify.shfailed withlogin shell's node is ~/.local/bin/node, not under ~/.local/share/mise.Cause. The stock Ubuntu
~/.profilesources~/.bashrcfirst. The mise block at the top of~/.bashrcadds the shims, then the stock lines prepend~/.local/bin. The~/.profilemise block only acted when the shims were absent, so they stayed second. Every stale~/.local/bincopy won in login bash (the reconcile timer's shell): the tarball node, an old starship. zsh was unaffected because.zshenvusespath=(shims $path)withtypeset -U.Fix. The POSIX block prepends unless the shims are already first. A later duplicate entry is harmless.
Test. A stale
~/.local/bin/nodemust not win inbash -lc. Without the fix, ubuntu fails this test (77/78). With it, ubuntu and arch both pass 78/78. Arch hit one unrelated flake (install output contains module 'ssh') that passed on rerun.🤖 Generated with Claude Code
https://claude.ai/code/session_01S29GMkRB43pGsAUBUXwLdT