refactor: replace the custom client with @gathertown/webhook-object-sdk - #15
Merged
Conversation
GCO-2137 Remove custom client
Swap this for our 1P client - https://github.com/gathertown/webhook-objects/tree/main/packages/client |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gesposito
force-pushed
the
gco-2137-remove-custom-client
branch
from
July 20, 2026 13:52
1a29213 to
207e3d9
Compare
@gathertown/webhook-object-sdk
gesposito
force-pushed
the
gco-2137-remove-custom-client
branch
2 times, most recently
from
July 20, 2026 14:08
25d515e to
21d8ab6
Compare
gesposito
force-pushed
the
gco-2137-remove-custom-client
branch
from
July 20, 2026 14:42
e8ae3c5 to
a5f6f1f
Compare
gesposito
marked this pull request as ready for review
July 20, 2026 14:44
yaustar
approved these changes
Jul 20, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a5f6f1f. Configure here.
gesposito
added a commit
that referenced
this pull request
Jul 20, 2026
The workspace @webhook-objects/client is being removed in favor of the npm-published SDK (see #15): createWebhookObjectClient replaces new Client, send takes (type, data) and stamps the timestamp itself, and ping() replaces requestMetadata(). The @gathertown packages join the minimumReleaseAge exclusions since they are first-party. Co-authored-by: Cursor <cursoragent@cursor.com>
gesposito
added a commit
that referenced
this pull request
Jul 20, 2026
The workspace @webhook-objects/client is being removed in favor of the npm-published SDK (see #15): createWebhookObjectClient replaces new Client, send takes (type, data) and stamps the timestamp itself, ping() replaces requestMetadata(), and the client type is WebhookObjectClient. The @gathertown packages join the minimumReleaseAge exclusions since they are first-party. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Removes the hand-rolled
packages/clientnow that the official SDK is on npm, and migrates all four demos to@gathertown/webhook-object-sdk.new Client({ url, secret })→createWebhookObjectClient(...);client.send({ type, timestamp, data })→client.send(type, data), the SDK stamps timestamps itself, and empty-payload events (counter.reset,activity.clear, …) take no argument.@vitest/browser*/playwrightroot devDeps and the CI Playwright install step; removed theundiciexternal from the claude-status bundle (the SDK uses the global fetch); updated the demo READMEs.minimumReleaseAgeExclude, the 7-day age gate would otherwise block them until a week after each release.Test plan
pnpm lint,pnpm -r build,pnpm -r testall green (12 tests)Note
Medium Risk
Behavior now depends on an external SDK’s signing, timestamps, and retry semantics instead of the removed in-repo client; webhook delivery changes are possible across all demos.
Overview
Removes the entire
packages/clientworkspace package (client implementation, object types, and its Vitest browser/Playwright test setup) in favor of the published@gathertown/webhook-object-sdk(^0.1.1) and@gathertown/webhook-object-typeswhere types are needed.All four demos (claude-status, gh-prs-inbox, low-battery-switch, now-playing-inbox) now use
createWebhookObjectClientand the SDK’sclient.send(eventType, data)API instead of building full{ type, timestamp, data }payloads; empty-payload events callsendwith no second argument. claude-status passesAbortSignal.timeout(3s)on the client so the whole send (including retries) is capped. Status typing comes from@gathertown/webhook-object-types. now-playing-inbox no longer sendscounter.incrementafter each new track.Tooling: root Playwright /
@vitest/browser*devDependencies and the CI Playwright Chromium install step are removed.pnpm-workspace.yamlallow-lists the two Gather SDK packages underminimumReleaseAgeExclude. Demo READMEs point at the npm SDK.Reviewed by Cursor Bugbot for commit a5f6f1f. Bugbot is set up for automated code reviews on this repo. Configure here.