Fix special characters in arguments - #51
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a string-escape/injection issue in argument parsing by preventing backslash escapes (e.g., \n) from being interpreted as real newlines during the “should we eval this?” check, which previously could cause docopt output to be mis-parsed and unsafe evaluation decisions.
Changes:
- Replace
echo -eusage in_is_str_to_evalwith a here-string pipeline to avoid interpreting escape sequences. - Update/extend tests to cover multi-line export blocks and literal
\ncontent. - Tighten
eval_argstest expectations to validate actual exported values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
core/helpers/cli_parse_args.sh |
Stops interpreting escape sequences while deciding whether docopt output is safe to eval. |
tests/core/helpers/test_cli_parse_args.sh |
Adds/updates tests for multi-line export detection and literal backslash-n handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Error: ``` Every function in a helper file should have a corresponding test (test coverage = 100%)... comm: file 1 is not in sorted order comm: file 2 is not in sorted order comm: input is not in sorted order ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix string injection:
With the proposed changes in this PR: