Allow expansion of env vars in options - #52
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for expanding environment variables inside docopt option defaults (from the help/docstring), enabling defaults like $HOME or ${FOO} to resolve at parse time while keeping user-supplied values unexpanded.
Changes:
- Expand
$VAR/${VAR}inside[default: ...]when parsing option descriptions indocopt_ng. - Add shell tests verifying default expansion, non-expansion of user input, unset-var behavior, and inert handling of
$(...). - Adjust the
bash_quote()docstring formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/core/helpers/test_cli_parse_args.sh | Adds test coverage asserting env-var expansion behavior for docstring defaults and non-expansion for user input. |
| scripts/doc_parser/docopt_ng/init.py | Implements env-var expansion for parsed defaults and introduces expand_env_vars() used during option parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.