Skip to content

Handling of encoding #105

Description

@melmothx

It occurred to me that the lines returned by Git::Wrapper are octects, not characters. I understand that this is undertested, given that most of us write commit messages in English/ASCII only, however, looking at the source, it seems that no attempt to decode the strings is done.

This is not a bug per se, but I'd suggest to formalize this in the documentation, so people using the module are aware of what kind of strings to expect.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions