Ignore Go To Definitions for code inside comments and strings - #162
Open
oisanjaya wants to merge 7 commits into
Open
Ignore Go To Definitions for code inside comments and strings#162oisanjaya wants to merge 7 commits into
oisanjaya wants to merge 7 commits into
Conversation
Replace the manual comment-checking function with a more robust GetContextAtPosition procedure that tracks strings and different types of comments during parsing. This prevents trigger definition lookups while the cursor is inside strings or comment blocks.
Owner
|
This approach feels wrong to me in general. Doesn't code tools know where comments and keywords are? That information but be in there somewhere. Maybe have the LLM search in the code tools source and see if it can find anything. |
Contributor
Author
|
Update checking using CodeTools API. But checks were not successful eventhough i successfully built on my machine and test run without failure |
Contributor
Author
|
Do we have minimum/maximum requirement version of fpc? I develop this PR using fpc 3.3.1 but Action runner for this repo is run on 3.2.2 which fail to build my PR. I thought "Requires Free Pascal Compiler version 3.2.0 and Lazarus trunk sources." in readme was a minimum requirement
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't call CodeToolBoss.FindMainDeclaration inside comments and strings.
I believe it also fixes #151