Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redact authentication-bearing values before Bolt protocol fields are written to logs.
Bolt HELLO, LOGON, and other message diagnostics currently serialize JSON fields directly. Authentication credentials can therefore appear in logs at
infoordebuglevel. This change keeps safe protocol metadata visible while replacing sensitive values with<redacted>.Changes
password,credentials,secret,token,authorization, andauth.principal,author, anddatabase.Security impact
This prevents authentication material from being emitted through the shared
bolt_value_to_stringlogging path. It does not change Bolt protocol behavior, authentication configuration, or query execution.Verification
Verified in the repository's CI-matched Rust 1.92 Linux container:
All commands passed.
The Windows full suite also ran locally. Existing corpus and SQL-golden failures were confirmed to be CRLF/LF-only mismatches in the Windows checkout; no semantic SQL differences were found. Those unrelated baseline issues are not included in this PR.