feat: implement AAP and migrate orchestrator - #1331
Open
geoffjay wants to merge 7 commits into
Open
Conversation
The installer only copied binaries listed in SERVICES (port-bound services) plus the CLI. AAP adapter binaries (agentd-adapter-*) are not services, so they were never installed. The orchestrator resolves an adapter as a sibling of its own binary, so a missing adapter made every agent restart fail on reconcile with 'Failed to spawn agentd-adapter-claude', putting all agents into a failed state after install. Add an ADAPTER_BINARIES list and copy it in the macOS and Linux installers (and remove it in the Linux uninstall; macOS uninstall drops the whole bundle). Add new adapter types here as they are introduced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
This change is part of the following stack: Change managed by git-spice. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
===========================================
+ Coverage 49.19% 69.22% +20.03%
===========================================
Files 468 219 -249
Lines 31606 8926 -22680
Branches 3121 3083 -38
===========================================
- Hits 15547 6179 -9368
+ Misses 16027 2718 -13309
+ Partials 32 29 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: implement AAP and migrate orchestrator
chore: clean up docs
chore: clean up docs
chore: drop docker
fix(install): ship AAP adapter binaries with the installer
The installer only copied binaries listed in SERVICES (port-bound
services) plus the CLI. AAP adapter binaries (agentd-adapter-*) are not
services, so they were never installed. The orchestrator resolves an
adapter as a sibling of its own binary, so a missing adapter made every
agent restart fail on reconcile with 'Failed to spawn agentd-adapter-claude',
putting all agents into a failed state after install.
Add an ADAPTER_BINARIES list and copy it in the macOS and Linux
installers (and remove it in the Linux uninstall; macOS uninstall drops
the whole bundle). Add new adapter types here as they are introduced.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
fix: handle CORS correctly
fix: port edits in nemo config