Fix right-panel split removal and drop bounds - #2486
Open
brsbl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove splitbutton only while the right panel has multiple panes.Product decision
Info and Diff remain fixed. Making them closeable would change Cmd+W, Cmd+D, mobile, and persisted-layout behavior. This layer instead preserves the existing two-action model: the tab-pill × closes a closeable tab, while the pane-edge × removes a split without closing its tabs.
Before
The fixed Info and Diff panes had no remove-split affordance.
After
Each split pane exposes a keyboard-focusable, trailing
Remove splitbutton; no control is present after the layout returns to one pane.Validation
Remove splitbuttons, Enter removal, and both fixed tabs preserved after unsplitting.pnpm exec turbo run test --filter=@bb/app --force -- --run ...— 9 files, 159 tests passed across the stack.pnpm exec turbo run typecheck --filter=@bb/app— passed.pnpm exec turbo run lint --filter=@bb/app— 0 errors; existing warnings only.Closes #2450
BB-Thread-ID: thr_q8degf2y66