Skip to content

Improve follow-up environment story coverage - #2530

Open
brsbl wants to merge 1 commit into
bb/lower-composer-control-emphasis-thr_sjdd7gudiqfrom
bb/improve-follow-up-environment-stories-thr_sjdd7gudiq
Open

Improve follow-up environment story coverage#2530
brsbl wants to merge 1 commit into
bb/lower-composer-control-emphasis-thr_sjdd7gudiqfrom
bb/improve-follow-up-environment-stories-thr_sjdd7gudiq

Conversation

@brsbl

@brsbl brsbl commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The follow-up composer story catalog defaulted every Row without an explicit environment fixture to the same local-direct summary, so most functional states repeated one environment treatment. The focused environment matrix covered only direct local/remote and managed local/remote worktrees; it omitted unmanaged, named, and detached worktree shapes, and the detached fixture omitted its machine label so its worktree icon could not render.

What changed

  • Rotates the functional overview through a balanced mix of local/remote and direct/worktree summaries instead of relying on the local default.
  • Expands Environment matrix with unmanaged, named, and detached worktree rows.
  • Supplies the detached fixture's machine label so the production FolderGit environment icon is visible.
  • Keeps provisioning on the production Loading spinner because discovery has not yet confirmed the eventual workspace type.
  • Changes only Ladle fixtures; there are no product, daemon-wire, SDK, API, CLI, or persistence changes.

Before — parent PR head f048e1c4003436c6d9807b10efb9569eaae5ac66

The matrix stopped after managed local/remote worktrees, and generic overview rows overwhelmingly inherited the local-direct fixture.

Before — incomplete environment matrix

After — child head fe499287001b0aa05454bcae2a3a33eb8a19374c

The matrix exposes every meaningful label/icon shape, while the overview exercises a balanced direct/worktree mix.

After — expanded environment matrix

How you verified

  • Verified live registration from Ladle's /meta.json: thread--timeline--rows--tool--native-skill-call and promptbox--follow-up-prompt-box--environment-matrix both exist.
  • Chrome for Testing 152.0.7977.64 rendered both exact routes without a missing-story state or runtime exception. The native-skill story rendered Loaded skill · visual-qa-loop with the Zap icon.
  • The exact child-head environment matrix rendered eight composers: provisioning uses Loading; direct local/remote use Laptop; managed, unmanaged, named, and detached worktrees use FolderGit; destroyed uses the archived banner. Every environment-type accessible label matched its fixture.
  • The exact child-head overview rendered 21 composers with 9 Laptop, 11 FolderGit, and 1 Loading environment treatments, with no horizontal overflow at 1440×1100.
  • pnpm exec turbo run typecheck --filter=@bb/app passed on the final head.
  • pnpm exec turbo run lint --filter=@bb/app completed with 0 errors; the repository's existing warnings remain.
  • Targeted oxfmt --check and git diff --check passed.
  • Safari is not required for this non-marketing Ladle change.

BB-Thread-ID: thr_sjdd7gudiq

AGENT GENERATED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant