Skip to content

feat: ship with open judgment criteria instead of looping - #110

Merged
naashw merged 1 commit into
developfrom
feat/judgment-ships
Aug 30, 2026
Merged

feat: ship with open judgment criteria instead of looping#110
naashw merged 1 commit into
developfrom
feat/judgment-ships

Conversation

@naashw

@naashw naashw commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • A judgment acceptance criterion no longer stalls a task: the reviewer must decide it (satisfied/unsatisfied, one-line rationale), and unclear requires the precise missing-information question.
  • When the only blockers left are unclear judgment criteria, the task ships instead of looping or escalating: the MR description carries a "To decide" section (criterion + the reviewer's question), and auto-merge / ready_to_merge is held with the new criteria_judgment_open reason until a human merges (the merge is the decision).
  • Safety cap: at most 2 review rounds where the only complaint is an undecided judgment criterion.
  • Reference incident: 12 auto-fix rounds then a blocking human question on a style criterion, ending in review_ko with no MR.

Verification

  • Suites 6191 pass / 1 skip / 0 fail (cli + web + contract), typecheck, oxlint 0 error, knip 0, prettier.
  • Contract extended backward-compatibly (CriterionVerdict.question, no version bump; grounding bug fixed: the question was dropped on the demote/unclear paths).

🤖 Generated with Claude Code

@naashw
naashw added this pull request to the merge queue Aug 30, 2026
Merged via the queue into develop with commit f58a2d8 Aug 30, 2026
5 checks passed
@naashw
naashw deleted the feat/judgment-ships branch August 30, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant