fix(task-trackers): look up Linear issues by id, not IssueFilter.identifier - #10
Merged
Conversation
…tifier Linear's IssueFilter has no identifier field, so fetching a task like DAN-6 failed with GRAPHQL_VALIDATION_FAILED before implementation started. Use the documented issue(id:) query, which accepts both identifiers and UUIDs. Signed-off-by: Daniil Pokrovsky <daniil.pokrovsky@gmail.com>
`devintern dan-6 dan-7 dan-8` already used the batch loop, but Linear identifiers were not covered by tests or help. Normalize each argument (uppercase, unwrap linear.app URLs) independently so all keys are fetched in order, and document the multi-issue form. Signed-off-by: Daniil Pokrovsky <daniil.pokrovsky@gmail.com>
Contributor
Author
|
@devintern-internal let's bump code/ package version (patch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devintern DAN-6 --create-pr --auto-reviewfailed immediately on fetch with:--create-prand--auto-reviewnever ran. The Linear client looked up issues withissues(filter: { identifier: { eq } }), but Linear'sIssueFilterhas noidentifierfield.This switches
getIssueByIdentifierandgetIssueIdByIdentifierto the documentedissue(id:)query, which accepts both human identifiers (DAN-6) and UUIDs. Missing issues still resolve toundefined(including Linear'sEntity not foundGraphQL error).Test plan
bun test packages/task-trackers/linear-client.test.ts packages/pm/backends.test.ts packages/code/tests/linear-task-tracker-client.test.tsdevintern DAN-6 --create-pr --auto-reviewagainst a real Linear workspace and confirm the issue is fetched