Skip to content

fix(deploy): a hosted push never stops at a git username prompt; deploy prints only what needs attention - #436

Merged
pdonohoe02 merged 1 commit into
mainfrom
claude/project-thread-gy85j5
Nov 18, 2026
Merged

pdonohoe02 merged 1 commit into
mainfrom
claude/project-thread-gy85j5

Conversation

@pdonohoe02

Copy link
Copy Markdown
Contributor

Requested by Patrick · project thread

Summary

  • floo deploy --hosted could hang at Username for 'https://github.com/floo-managed/...'. git asked floo's credential helper for the push token; when that API call failed or timed out (it can wait ~20s on a new repo), git fell back to a terminal prompt and the helper's error stayed hidden in piped stderr.
  • floo now fetches the token before git runs, so a failure stops with floo's own error and floo deploy as the next command. git runs with GIT_TERMINAL_PROMPT=0 and an empty GIT_ASKPASS, so it can never prompt.
  • Plain floo deploy prints only warnings and errors from its config check, not the full preflight report. --preflight keeps the report, minus the "legacy implicit" injection note, the plan-limit note and confidence levels.

Issue Closure (Required)

N/A: reported directly by Patrick in the project thread while deploying a new app.

Changes

  • src/commands/ship.rs: hosted_git fetches the token and returns Result; passes it to the helper via FLOO_GIT_APP_ID/FLOO_GIT_TOKEN; disables git prompts. Org-only access note drops "gets 401".
  • src/commands/projects.rs: floo git-credential uses the handed-over token only when it is for the requested app, else asks the API as before (for floo clone checkouts).
  • src/commands/connect.rs: uses the new hosted_git result, so a token failure keeps the scratch cleanup.
  • src/commands/deploy.rs: push mode prints warnings only; removed print_preflight_ready (the git push contract + golden-path link), the always-printed plan-limit note, the confidence suffix, the injection mode line and the env_injection_plan.notes field (its one note said "legacy" about the normal default).

Test Plan

  • cargo clippy --all-targets clean
  • cargo test --no-fail-fast: all pass
  • New: a_push_token_floo_cannot_get_stops_before_git_runs, credential_get_uses_the_token_floo_handed_over_for_that_app_only; the hosted push test asserts the token was fetched and git ran with prompts off.

Discovered Issues

  • The API returns github.com/floo-managed/... URLs to customers (source.repo, git-token.clone_url), so GitHub still shows up in remotes and git errors. Hiding it needs a floo git endpoint; Patrick is deciding in the thread.

Generated by Claude Code

…oy prints only what needs attention

floo deploy to a floo-hosted repo let git ask floo's credential helper for
the push token. When that API call failed or timed out, git fell back to a
terminal "Username for https://github.com/..." prompt, and the helper's error
sat unread in the piped stderr, so the deploy looked hung.

floo now fetches the token before git runs and hands it to the helper through
the environment (bound to the app id), so a failure stops with floo's own
error and next command. git runs with GIT_TERMINAL_PROMPT=0 and an empty
GIT_ASKPASS, so it can never prompt.

Plain floo deploy no longer prints the full preflight report (env injection
mode, confidence levels, plan-limit notes, the git push contract); it shows
warnings and errors only. floo deploy --preflight keeps the report, without
the "legacy implicit" and plan-limit notes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Eufw45htq3J3MNrsAyXJfZ
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T18:47:26.787989Z e874426 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pdonohoe02
pdonohoe02 merged commit 6bbb2b5 into main Nov 18, 2026
7 checks passed
@pdonohoe02
pdonohoe02 deleted the claude/project-thread-gy85j5 branch November 18, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants