Repository navigation
fix(deploy): a hosted push never stops at a git username prompt; deploy prints only what needs attention - #436
Merged
Conversation
…oy prints only what needs attention floo deploy to a floo-hosted repo let git ask floo's credential helper for the push token. When that API call failed or timed out, git fell back to a terminal "Username for https://github.com/..." prompt, and the helper's error sat unread in the piped stderr, so the deploy looked hung. floo now fetches the token before git runs and hands it to the helper through the environment (bound to the app id), so a failure stops with floo's own error and next command. git runs with GIT_TERMINAL_PROMPT=0 and an empty GIT_ASKPASS, so it can never prompt. Plain floo deploy no longer prints the full preflight report (env injection mode, confidence levels, plan-limit notes, the git push contract); it shows warnings and errors only. floo deploy --preflight keeps the report, without the "legacy implicit" and plan-limit notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eufw45htq3J3MNrsAyXJfZ
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Patrick · project thread
Summary
floo deploy --hostedcould hang atUsername for 'https://github.com/floo-managed/...'. git asked floo's credential helper for the push token; when that API call failed or timed out (it can wait ~20s on a new repo), git fell back to a terminal prompt and the helper's error stayed hidden in piped stderr.floo deployas the next command. git runs withGIT_TERMINAL_PROMPT=0and an emptyGIT_ASKPASS, so it can never prompt.floo deployprints only warnings and errors from its config check, not the full preflight report.--preflightkeeps the report, minus the "legacy implicit" injection note, the plan-limit note and confidence levels.Issue Closure (Required)
N/A: reported directly by Patrick in the project thread while deploying a new app.
Changes
src/commands/ship.rs:hosted_gitfetches the token and returnsResult; passes it to the helper viaFLOO_GIT_APP_ID/FLOO_GIT_TOKEN; disables git prompts. Org-only access note drops "gets 401".src/commands/projects.rs:floo git-credentialuses the handed-over token only when it is for the requested app, else asks the API as before (forfloo clonecheckouts).src/commands/connect.rs: uses the newhosted_gitresult, so a token failure keeps the scratch cleanup.src/commands/deploy.rs: push mode prints warnings only; removedprint_preflight_ready(thegit pushcontract + golden-path link), the always-printed plan-limit note, the confidence suffix, the injection mode line and theenv_injection_plan.notesfield (its one note said "legacy" about the normal default).Test Plan
cargo clippy --all-targetscleancargo test --no-fail-fast: all passa_push_token_floo_cannot_get_stops_before_git_runs,credential_get_uses_the_token_floo_handed_over_for_that_app_only; the hosted push test asserts the token was fetched and git ran with prompts off.Discovered Issues
github.com/floo-managed/...URLs to customers (source.repo,git-token.clone_url), so GitHub still shows up in remotes and git errors. Hiding it needs a floo git endpoint; Patrick is deciding in the thread.Generated by Claude Code