Repository navigation
fix(security): harden the release workflow and patch vulnerable crates - #437
Merged
Merged
Conversation
Release: delete the signing key file when the signing step exits, so the third-party release action never shares a runner disk with it; pin every action to a commit SHA; install cross at a fixed commit with --locked; default the workflow token to contents: read; publish only from tag refs; attest build provenance with Sigstore. Deps: bump rustls, rustls-webpki, webpki-roots, tokio, h2, quinn-proto, quinn-udp, rustix and anyhow to their fixed versions, and audit Cargo.lock in CI with a pinned, checksummed osv-scanner. Two unmaintained notices (chrono, pin-utils) are accepted until 2027-02-19. CODEOWNERS named a login that is not Patrick's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eufw48dfQicJDJDW3hCXRo
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Patrick · project thread
Summary
crossinstalls at a fixed commit, and releases carry a Sigstore build-provenance attestation.Issue Closure (Required)
Closes getfloo/floo#4670
Part of getfloo/floo#4669 and getfloo/floo#4671. Those stay open for the settings changes: a
releaseenvironment for the signing key, a tag ruleset, and required SHA pinning.Changes
.github/workflows/release.yml:permissions: contents: readid-token/attestationswrite foractions/attest-build-provenancetrap)cargo install cross --locked --rev a9301e9(the same commit as cross-rs HEAD, which built v2026.11.18).github/workflows/ci.yml: actions SHA-pinned. A newAudit dependencies (osv-scanner)step downloads osv-scanner v2.4.0, checks its SHA-256, and scansCargo.lock.osv-scanner.toml: accepts RUSTSEC-2026-0543 (chrono unmaintained) and RUSTSEC-2026-0441 (pin-utils unmaintained, via hyper) until 2027-02-19.Cargo.lock:cargo update --preciseto the first fixed version only for: anyhow 1.0.103, h2 0.4.16, quinn-proto 0.11.19, quinn-udp 0.5.16, rustix 1.1.6, rustls 0.23.46, rustls-webpki 0.103.16, tokio 1.51.6, webpki-roots 1.0.10. This is not a blanket update, so the Dependabot cooldown policy still holds for everything else..github/CODEOWNERS:@patrickdonohoe→@pdonohoe02.Test Plan
./scripts/test(fmt, clippy, all tests) passes locally with the new lockosv-scanner scan --offline-vulnerabilities --lockfile Cargo.lock: no issues (2 accepted notices filtered)Discovered Issues
Generated by Claude Code