Skip to content

fix(security): harden the release workflow and patch vulnerable crates - #437

Merged
pdonohoe02 merged 1 commit into
mainfrom
claude/project-thread-vrkpef
Nov 19, 2026
Merged

pdonohoe02 merged 1 commit into
mainfrom
claude/project-thread-vrkpef

Conversation

@pdonohoe02

Copy link
Copy Markdown
Contributor

Requested by Patrick · project thread

Summary

  • The release signing key no longer sits on the runner's disk while third-party actions run, every action is pinned to a commit SHA, cross installs at a fixed commit, and releases carry a Sigstore build-provenance attestation.
  • Patches the vulnerable crates in the CLI (rustls, tokio, h2, quinn-proto and others) and adds an osv-scanner dependency audit to CI.

Issue Closure (Required)

Closes getfloo/floo#4670

Part of getfloo/floo#4669 and getfloo/floo#4671. Those stay open for the settings changes: a release environment for the signing key, a tag ruleset, and required SHA pinning.

Changes

  • .github/workflows/release.yml:
    • workflow-wide permissions: contents: read
    • the release job runs only on tag refs and gains id-token/attestations write for actions/attest-build-provenance
    • the signing step deletes the key file on exit (trap)
    • cargo install cross --locked --rev a9301e9 (the same commit as cross-rs HEAD, which built v2026.11.18)
    • all actions SHA-pinned with version comments, which Dependabot keeps current
  • .github/workflows/ci.yml: actions SHA-pinned. A new Audit dependencies (osv-scanner) step downloads osv-scanner v2.4.0, checks its SHA-256, and scans Cargo.lock.
  • osv-scanner.toml: accepts RUSTSEC-2026-0543 (chrono unmaintained) and RUSTSEC-2026-0441 (pin-utils unmaintained, via hyper) until 2027-02-19.
  • Cargo.lock: cargo update --precise to the first fixed version only for: anyhow 1.0.103, h2 0.4.16, quinn-proto 0.11.19, quinn-udp 0.5.16, rustix 1.1.6, rustls 0.23.46, rustls-webpki 0.103.16, tokio 1.51.6, webpki-roots 1.0.10. This is not a blanket update, so the Dependabot cooldown policy still holds for everything else.
  • .github/CODEOWNERS: @patrickdonohoe → @pdonohoe02.

Test Plan

  • ./scripts/test (fmt, clippy, all tests) passes locally with the new lock
  • osv-scanner scan --offline-vulnerabilities --lockfile Cargo.lock: no issues (2 accepted notices filtered)
  • Both workflows parse as YAML. Release-path steps (attestation, tag guard) can only run on the next tag. If attestation fails, the release job stops before publishing, and the next three-part tag retries.

Discovered Issues

  • getfloo/floo#4669: the signing key is a plain repo secret and release tags are not protected (settings).

Generated by Claude Code

Release: delete the signing key file when the signing step exits, so the
third-party release action never shares a runner disk with it; pin every
action to a commit SHA; install cross at a fixed commit with --locked;
default the workflow token to contents: read; publish only from tag refs;
attest build provenance with Sigstore.

Deps: bump rustls, rustls-webpki, webpki-roots, tokio, h2, quinn-proto,
quinn-udp, rustix and anyhow to their fixed versions, and audit
Cargo.lock in CI with a pinned, checksummed osv-scanner. Two unmaintained
notices (chrono, pin-utils) are accepted until 2027-02-19.

CODEOWNERS named a login that is not Patrick's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Eufw48dfQicJDJDW3hCXRo
@pdonohoe02 pdonohoe02 self-assigned this Nov 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T04:12:49.597499Z 967975d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pdonohoe02
pdonohoe02 merged commit 9a54a4b into main Nov 19, 2026
7 checks passed
@pdonohoe02
pdonohoe02 deleted the claude/project-thread-vrkpef branch November 19, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants