Skip to content

ci(release): sign in the tag-only release environment - #439

Merged
pdonohoe02 merged 1 commit into
mainfrom
claude/project-thread-vrkpef
Nov 19, 2026
Merged

pdonohoe02 merged 1 commit into
mainfrom
claude/project-thread-vrkpef

Conversation

@pdonohoe02

Copy link
Copy Markdown
Contributor

What changed

The release job now runs in the release environment, so FLOO_RELEASE_SIGNING_KEY can live in an environment that only v* and cli-v* tags may use instead of a repo secret that any workflow on any branch can read.

The change is safe on its own. Until the key moves, the repo-level secret still reaches the job, so the next tag release works either way.

Why

CI/supply-chain audit 11-19 (getfloo/floo#4669). The key signs every installer the CLI trusts. Today any branch workflow, including one pushed by a GitHub App, can read it.

Steps for Patrick in repo settings (after merge)

  1. Settings → Environments → release → Deployment branches and tags → Selected → add tag rules v* and cli-v*.
  2. Add environment secret FLOO_RELEASE_SIGNING_KEY with the same value.
  3. Delete the repo-level FLOO_RELEASE_SIGNING_KEY.

Verified by running

  • python3 -c 'import yaml; ...': the workflow parses and jobs.release.environment == "release".

Deliberately not building

  • No required reviewers on the environment (no new human gates).

Refs getfloo/floo#4669


Generated by Claude Code

The release job runs in the `release` environment, so the signing key can
move from a repo secret into an environment only v*/cli-v* tags may use.
Until it moves, the repo secret still reaches the job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Eufw48dfQicJDJDW3hCXRo
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T17:21:27.258871Z e2c86d4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pdonohoe02
pdonohoe02 merged commit 93e7123 into main Nov 19, 2026
7 checks passed
@pdonohoe02
pdonohoe02 deleted the claude/project-thread-vrkpef branch November 19, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants