Repository navigation
ci(release): sign in the tag-only release environment - #439
Merged
Merged
Conversation
The release job runs in the `release` environment, so the signing key can move from a repo secret into an environment only v*/cli-v* tags may use. Until it moves, the repo secret still reaches the job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eufw48dfQicJDJDW3hCXRo
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
releasejob now runs in thereleaseenvironment, soFLOO_RELEASE_SIGNING_KEYcan live in an environment that onlyv*andcli-v*tags may use instead of a repo secret that any workflow on any branch can read.The change is safe on its own. Until the key moves, the repo-level secret still reaches the job, so the next tag release works either way.
Why
CI/supply-chain audit 11-19 (getfloo/floo#4669). The key signs every installer the CLI trusts. Today any branch workflow, including one pushed by a GitHub App, can read it.
Steps for Patrick in repo settings (after merge)
release→ Deployment branches and tags → Selected → add tag rulesv*andcli-v*.FLOO_RELEASE_SIGNING_KEYwith the same value.FLOO_RELEASE_SIGNING_KEY.Verified by running
python3 -c 'import yaml; ...': the workflow parses andjobs.release.environment == "release".Deliberately not building
Refs getfloo/floo#4669
Generated by Claude Code