Skip to content

Site Path #524

Closed
Closed

Description

@Wemago

Shouldn't $site->path() return the site folder path?
Currently it's returning site content folder path.

Activity

  1. giuscris commented on Jun 3, 2024

    @giuscris
    Member

    This is because $site actually represents the content root, and so page traversal is allowed even if the page parent is a Site object. If you call $page->parent()->path() you have the expected result.

    Maybe the naming could be reviewed in Formwork 2.0, splitting Site from pages logic for good and also the content folder should be renamed to "pages".

    I'm not afraid of breaking changes, as Formwork 1.0 is almost entirely rewritten.

  2. locked and limited conversation to collaborators on Jun 3, 2024
  3. converted this issue into a discussion #525 on Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions