fix(list): forward justify to filter controls - #192
Merged
Conversation
`justify` reached the section wrapper and the heading, but not the table. The section applies it to the column as a whole, so with a `width` set it centered the column and left its contents flush left — a centered heading above a left-aligned filter button group. Forward the argument to assets/table.html, which positions the filter row only. The table still spans the full width of its container. Merged in only when the author set it, rather than passed on every call. Hinode is a separate module that a site resolves independently — it does not import mod-blocks — and `justify` reached the table structure in hinode v3.18.0. An older copy rejects an unknown argument whatever its value, so an unconditional forward would break every list block for anyone updating mod-blocks alone. Guarding it means only the authors who set `justify` need the newer hinode. Bump exampleSite to hinode v3.18.0 and add a centered, filtered list fixture that renders `justify-content-center`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
markdumay
force-pushed
the
fix/list-filter-justify
branch
from
August 3, 2026 08:25
699b44d to
2064220
Compare
markdumay
marked this pull request as ready for review
August 3, 2026 08:25
markdumay
enabled auto-merge
August 3, 2026 08:27
Contributor
Author
|
🎉 This PR is included in version 2.3.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocked: gethinode/hinode#2115 shipped as hinode v3.18.0.
Problem
justifyon thelistblock reached the section wrapper and the heading, but never the table.utilities/section.htmlapplies it asalign-items-*to the column as a whole. With awidthset, that centers thecol-12 col-md-*wrapper and leaves its contents flush left, whileassets/section-title.htmlseparately centers the heading viamx-auto. On a filtered list the result is a centered heading above a left-aligned filter button group.Change
Forward
justifyinto$tableArgssoassets/table.htmlcan position the filter row. The table itself is unaffected — it spans the full width of its container either way.Merged in only when the author set it, rather than passed on every call:
Hinode is a separate module that a site resolves independently — it does not import mod-blocks — so the two versions can move apart.
justifyreached the table structure only in hinode v3.18.0, and an older copy rejects an unknown argument whatever its value. An unconditional forward therefore broke every list block for anyone updating mod-blocks alone:Guarding it narrows the requirement to the authors who actually set
justify.Verification
pnpm testpasses.exampleSite/go.modbumped to hinode v3.18.0exampleSite/content/components/list.md, which renders:justifyset. Clean build. The unconditional version failed the same build on every list block, which is what motivated the guard.Also verified end-to-end in a consuming site: the affected page renders the heading and the filter bar aligned.
Note
The earlier revision of this branch was committed with
--no-verify, since its build could not pass before v3.18.0 existed. That is no longer the case — the hook passes on its own now.🤖 Generated with Claude Code