Repository navigation
Conversation
ianrahman
marked this pull request as draft
September 11, 2026 21:01
ianrahman
force-pushed
the
codex/configurable-test-products-retention
branch
from
September 21, 2026 20:17
fd7ba73 to
a13bedb
Compare
ianrahman
marked this pull request as ready for review
September 21, 2026 20:35
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
This PR has been inactive for 21 days. It will be closed in 7 days if no further activity occurs. Add a comment to keep it open, or apply the |
|
I would like to have these configuration options as well. |
ianrahman
force-pushed
the
codex/configurable-test-products-retention
branch
from
October 13, 2026 12:43
43704d9 to
b1f6d18
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b1f6d18. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make managed
.xctestproductsretention configurable through.mobilebuildmcp/config.yamlorMOBILEBUILDMCP_TEST_PRODUCTS_MAX_COUNT/MOBILEBUILDMCP_TEST_PRODUCTS_MAX_AGE_DAYS, defaulting to three bundles for one day.Prune under the workspace lifecycle lock, protect active readers and caller-owned bundles, and preserve completed products after cleanup or metadata errors while surfacing the original error.
The global unit setup already isolates storage; device/macOS suites now assert this before lifecycle work.
Validation
177 focused tests pass; omitting unit setup correctly fails the new guards. Build, typecheck, formatting, and strict lint on freshly touched TypeScript files pass. Full unit suite: 2,630 passed, one unchanged init home-path failure. Global strict lint retains 105 existing warnings. Snapshot/smoke suites were not run. xhigh review was unavailable due to capacity; local review completed.
Fixes #524.
AI assistance: Heavy AI use; human review is limited.