Repository navigation
fix(tests): Expect React login page in integration tests - #4551
Merged
Merged
Conversation
Sentry now enables React authentication by default (getsentry/sentry#126486). The login page is served at /auth/login/ instead of redirecting to /auth/login/sentry/, and it has no form to read the CSRF token from, so take the token from the CSRF cookie instead. Co-Authored-By: Claude <noreply@anthropic.com>
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 9m 38s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (3 of 3 changed executable lines covered; target 50%). Changed files with executable lines (1)
Coverage diff@@ Coverage Diff @@
## master #4551 +/-##
==========================================
- Coverage 95.53% 95.52% -0.01%
==========================================
Files 5 5 —
Tracked lines 336 335 -1
Branches 0 0 —
==========================================
- Hits 321 320 -1
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |
evanpurkhiser
approved these changes
Oct 6, 2026
1 task done
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry now enables React authentication by default (getsentry/sentry#126486), which broke the integration tests on every branch, including master:
/now ends at/auth/login/instead of redirecting to/auth/login/sentry/.csrfmiddlewaretokenfrom. The login fixture now takes the token from thescCSRF cookie, which both login pages set.The login POST is unchanged: only GET requests are served by the React page.