Skip to content

fix(tests): Expect React login page in integration tests - #4551

Merged
oioki merged 1 commit into
masterfrom
alextarasov/integration-tests-react-auth
Oct 6, 2026
Merged

oioki merged 1 commit into
masterfrom
alextarasov/integration-tests-react-auth

Conversation

@oioki

@oioki oioki commented Oct 6, 2026

Copy link
Copy Markdown
Member

Sentry now enables React authentication by default (getsentry/sentry#126486), which broke the integration tests on every branch, including master:

  • / now ends at /auth/login/ instead of redirecting to /auth/login/sentry/.
  • The React login page has no form to read csrfmiddlewaretoken from. The login fixture now takes the token from the sc CSRF cookie, which both login pages set.

The login POST is unchanged: only GET requests are served by the React page.

Sentry now enables React authentication by default (getsentry/sentry#126486).
The login page is served at /auth/login/ instead of redirecting to
/auth/login/sentry/, and it has no form to read the CSRF token from, so
take the token from the CSRF cookie instead.

Co-Authored-By: Claude <noreply@anthropic.com>
@oioki
oioki requested a review from evanpurkhiser October 6, 2026 22:30
@oioki
oioki marked this pull request as ready for review October 6, 2026 22:30
@oioki
oioki requested a review from aldy505 October 6, 2026 22:38
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Coverage Results 📊

✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 9m 38s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (3 of 3 changed executable lines covered; target 50%).
Project statement coverage is 95.52% (down 0.01 percentage points from base (cd51aab) to head (43fdd1c)).

Changed files with executable lines (1)
File Patch coverage Changed executable lines
_integration-test/test_01_basics.py 100.00% 3/3 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #4551       +/-##
==========================================
- Coverage    95.53%    95.52%    -0.01%
==========================================
  Files            5         5         —
  Tracked lines       336       335        -1
  Branches         0         0         —
==========================================
- Hits           321       320        -1
  Misses          15        15         —
  Partials         0         0         —

Generated by Coverage Action

@oioki
oioki merged commit 7b07b5e into master Oct 6, 2026
22 of 23 checks passed
@oioki
oioki deleted the alextarasov/integration-tests-react-auth branch October 6, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants