Repository navigation
ref(vroom): Remove ensure-correct-permissions-profiles-dir.sh - #4554
Merged
Merged
Conversation
It was marked for removal after the next hard stop, and 26.5.0 and 26.7.0 have shipped since. It also runs bash inside the vroom container, which a distroless vroom image won't have. Co-Authored-By: Claude <noreply@anthropic.com>
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 11m 5s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 50%). Coverage diff@@ Coverage Diff @@
## master #4554 +/-##
==========================================
Coverage 95.52% 95.52% —%
==========================================
Files 5 5 —
Tracked lines 335 335 —
Branches 0 0 —
==========================================
Hits 320 320 —
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |
oioki
marked this pull request as ready for review
October 7, 2026 15:46
aldy505
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
install/ensure-correct-permissions-profiles-dir.shand its call ininstall.sh. It runsbashas root inside the vroom container to chown thesentry-vroomvolume, which won't work once the vroom image has no shell. This is the last placeinstall.shshells into vroom.Why it's safe: the script is marked
TODO: Remove this after the next hard-stop, and 26.5.0 and 26.7.0 have shipped since, so every supported install has already had the volume chowned. vroom no longer writes to that volume either: it stores profiles in the SeaweedFSprofilesbucket, and the copy out of the volume was removed in #4552. vroom keeps running as uid 1000, so existing volumes need no new ownership change.Worst case: someone who skipped the hard stops keeps a volume that isn't owned by vroom. Nothing writes to it any more, so install and vroom are unaffected.
Follow-up to #4552.