fix: Ensure URL and Auth Token come from same source#3378
Merged
Conversation
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Clear a more narrow set of env vars
The integration tests depend on UNIX platform specific behavior. We already cover these cases in the unit tests added, so I think this can be deleted safely
szokeasaurusrex
marked this pull request as ready for review
July 22, 2026 12:47
szokeasaurusrex
requested review from
loewenheim,
msonnb and
stephanie-anderson
and removed request for
msonnb and
stephanie-anderson
July 22, 2026 12:47
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
loewenheim
reviewed
Jul 22, 2026
loewenheim
approved these changes
Jul 22, 2026
|
runningcode
added a commit
to getsentry/sentry-android-gradle-plugin
that referenced
this pull request
Jul 23, 2026
sentry-cli 3.6.2 discards a non-embedded auth token when the URL is resolved from a different configuration source (getsentry/sentry-cli#3378). The sentry-cli integration test job supplies the URL via the SENTRY_URL environment variable while the tests wrote the auth token into sentry.properties, so the token would now be ignored and the uploads would fail with "Auth token is required". Provide the token via SENTRY_AUTH_TOKEN in the same CI job so the URL and token share a single runtime source, and drop the now-obsolete auth.token writes from the integration tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
The changes are intentional. Please see #3380 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SDK-1233