Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Attributes
Documentation 📚
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/bullmq-attributes
branch
from
October 9, 2026 09:30
b2de364 to
fc9eb9d
Compare
JPeer264
changed the title
JPeer264
marked this pull request as ready for review
October 9, 2026 10:20
JPeer264
requested review from
a team,
Lms24,
alexander-alderman-webb,
cleptric,
mjq and
nsdeschenes
as code owners
October 9, 2026 10:20
| /** | ||
| * Type for {@link BULLMQ_FLOW_NAME} bullmq.flow.name | ||
| */ | ||
| export type BULLMQ_FLOW_NAME_TYPE = string; |
Contributor
There was a problem hiding this comment.
I thought it was preferred to use the existing messaging.* attributes?
Member
Author
There was a problem hiding this comment.
Yeah we do for these values: https://github.com/getsentry/sentry-javascript/pull/21777/changes#diff-b231e1ca3c1e7c4c3f1f1deba1efd6a0d0f272621d92e62bbf1a4a0f51756213R22-R26
bullmq.flow.name would kinda be a messaging name, but we don't have an exact equivalent.
elramen
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This registers the attributes and metrics that the BullMQ integration of the JavaScript SDK sends (getsentry/sentry-javascript#21777). BullMQ sets them itself through its
telemetryinterface, and the SDK forwards them. The metrics areopt_in, because the SDK sends them only withenableMetrics: true.Naming decisions
The keys are the exact names BullMQ emits, also multi-word names with dots such as
bullmq.worker.do.not.wait.active. The five BullMQ attributes that have amessaging.*equivalent are not registered, because the SDK replaces them.Scrubbing decisions
apply_scrubbingisautofor values from user code (bullmq.job.progress,bullmq.job.deduplication.key,bullmq.job.key) andmanualfor all others.Known issues
bullmq.job.status(BullMQ 5) andbullmq.job.state(BullMQ 6) are the same metric attribute, renamed by BullMQ.PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)