Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A JDBC job store with useProperties only accepts String values. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
The plan checks Java page errors, Java not-found events, and code tab errors. An issue escalates when Java page errors or not-found events rise. The new heading has no telemetry signal. Services: Mention PlanWhat changedThe Quartz integration pages now show a Monitor Config section. The section states that SentryJobListener sends trigger-derived monitor config by default. It lists which triggers convert and how to turn upsert off. This change is live after RiskA bad static page can 404 the Quartz URLs. Java guides inherit this file, so those URLs change together. The new code sample can throw in the code tab UI. Intended effectThis change is a docs edit. No metric shows the new heading text. Mark Regression watchThe blast radius is the Java Quartz pages and the shared code tab UI. Watch Java URL errors and Java not-found events. Watch code tab errors because this diff adds a Java sample.
If Java URL errors rise, inspect client errors on code tabs and on Quartz paths. Common inherited URLs include Not observableThe live HTML for the Monitor Config heading is not in Sentry. Quartz |
|
|
||
| ## Monitor Config | ||
|
|
||
| From the next Sentry Java SDK release (after `8.59.0`), `SentryJobListener` sends a monitor config derived from the job's trigger with each check-in, so Sentry creates the monitor (or updates its schedule) from your code. This is on by default for every job that has a monitor slug. |
There was a problem hiding this comment.
Bug: The documentation contains a placeholder version string that was not replaced with the actual version number, leaving users unsure which SDK version is required.
Severity: LOW
Suggested Fix
Replace the placeholder text "the next Sentry Java SDK release (after 8.59.0)" with the correct, released version number of the Sentry Java SDK.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/platforms/java/common/integrations/quartz.mdx#L85
Potential issue: The documentation at
`docs/platforms/java/common/integrations/quartz.mdx:85` contains a placeholder version
string: "the next Sentry Java SDK release (after `8.59.0`)". This was intended to be
replaced with a specific version number before publication. Because this pre-merge step
was missed, users are unable to determine the exact SDK version required for the
described feature.
Did we get this right? 👍 / 👎 to inform future reviews.
| - `CronTrigger`: the cron expression and the trigger's time zone. The seconds field must be a fixed number, and the year field, if set, must be `*`. | ||
| - `SimpleTrigger` that repeats forever: the repeat interval, if it's a whole number of minutes. | ||
|
|
||
| Other triggers send no monitor config, and neither do triggers with a `Calendar`, jobs with more than one trigger, cron expressions with syntax Sentry doesn't support (such as `15W`, `L-3`, or wrap-around ranges like `FRI-MON`), a step after a day or month name (such as `MON/2`, which Quartz runs every Monday), or time zones that aren't IANA time zone IDs (whole-hour offsets such as `GMT+2` are sent as `Etc/GMT-2`). For these, create the monitor in Sentry first. |
There was a problem hiding this comment.
Bug: The documentation is self-contradictory regarding whether non-IANA timezones like GMT+2 will have monitors automatically created or require manual creation.
Severity: LOW
Suggested Fix
Clarify the documentation to state unambiguously whether the SDK automatically creates monitors for non-IANA timezones like GMT+2. If it does, remove the instruction to create them manually. If it does not, correct the statement that they are converted and sent.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/platforms/java/common/integrations/quartz.mdx#L92
Potential issue: The documentation regarding timezone handling is self-contradictory. It
first states that non-IANA time zones will not have a monitor config sent, but then
gives an example of a non-IANA timezone (`GMT+2`) that *is* converted and sent. It then
concludes by instructing users to manually create monitors for these cases, leaving it
unclear whether the SDK handles it automatically or if manual intervention is required.
Did we get this right? 👍 / 👎 to inform future reviews.
DESCRIBE YOUR PR
Adds a "Monitor Config" section to the Quartz integration page.
SentryJobListenersends a monitor config derived from the job's trigger by default, so Sentry creates the monitor from code. The section covers which triggers convert, the upgrade effect on existing monitors, and how to turn it off (SentryJobListener.SENTRY_UPSERT_MONITOR_CONFIG_KEYset to"false").SDK PR: getsentry/sentry-java#6216
Merge after the SDK release, and replace "the next Sentry Java SDK release (after
8.59.0)" with the released version.IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST