fix(tests): accept nil as the DSN value again - #1044
Merged
Merged
Conversation
solnic
marked this pull request as ready for review
April 29, 2026 10:18
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
solnic
force-pushed
the
fix/tests-accept-nil-dsn-again
branch
from
April 29, 2026 10:33
fda2a35 to
eb5615a
Compare
solnic
marked this pull request as draft
April 29, 2026 10:49
solnic
marked this pull request as ready for review
April 30, 2026 09:53
dingsdax
self-requested a review
April 30, 2026 13:04
dingsdax
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores pre-13.0.0 behavior in test mode where
nilDSN could be used along withstart_collecting_sentry_reports- it addresses report from #1043 comments.We're pushing handling of
nilDSN down to the Client which results in exercising more code in tests and still allowing report capture to kick in.I used it also as an excuse to add prod-specific integration tests as well that cover handling of
nilDSN in config.