Skip to content

fix(scrubbing): scrub conn path params (#1195) - #1197

Merged
solnic merged 1 commit into
fix/scrub-url-derived-conn-fieldsfrom
fix/scrub-conn-path-params
Sep 11, 2026
Merged

solnic merged 1 commit into
fix/scrub-url-derived-conn-fieldsfrom
fix/scrub-conn-path-params

Conversation

@solnic

@solnic solnic commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Now conn.path_params is scrubbed too, so a secret in a route segment is redacted like any other param.

Before

  • path_params%{"token" => "pathsecret-..."}, the raw route segment
pr2-conn-dump-before

After

  • path_params%{"token" => "*********"}
pr2-conn-dump-after

@solnic
solnic force-pushed the fix/scrub-conn-path-params branch 2 times, most recently from 63f5e8a to 33fea82 Compare September 8, 2026 11:28
@solnic
solnic force-pushed the fix/scrub-conn-path-params branch from 33fea82 to 2b73c21 Compare September 8, 2026 11:47
@solnic
solnic force-pushed the fix/scrub-conn-path-params branch from 2b73c21 to 2ad446f Compare September 8, 2026 12:04
@solnic
solnic marked this pull request as ready for review September 9, 2026 12:13
@solnic
solnic force-pushed the fix/scrub-conn-path-params branch from 2ad446f to d4aec57 Compare September 10, 2026 13:29
@solnic
solnic merged commit 381ae30 into master Sep 11, 2026
24 of 25 checks passed
@solnic
solnic deleted the fix/scrub-conn-path-params branch September 11, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants